ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sid Wagle" <swa...@hortonworks.com>
Subject Review Request 19707: Add new Maintenance States to support different operation levels.
Date Thu, 27 Mar 2014 00:43:18 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19707/
-----------------------------------------------------------

Review request for Ambari, Dmitro Lisnichenko and Sumit Mohanty.


Bugs: AMBARI-5234
    https://issues.apache.org/jira/browse/AMBARI-5234


Repository: ambari


Description
-------

1. The API calls to perform all backend operations needs to provide a “source” element
in the “RequestInfo” properties to identify the logical level at which the operation is
executed.

Possible levels:
{CLUSTER, SERVICE, HOST_COMPONENT, HOST}

Note: Service component is analogous to Service, no level specification needed at the moment.

2. The current states for Maintenance mode will be modified to add more context to the IMPLIED
state.


Diffs
-----

  ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariActionExecutionHelper.java
d392167 
  ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java
7f63a41 
  ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
951a619 
  ambari-server/src/main/java/org/apache/ambari/server/controller/MaintenanceStateHelper.java
690b83a 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostResourceProvider.java
6a45da9 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ServiceResourceProvider.java
ec96627 
  ambari-server/src/main/java/org/apache/ambari/server/state/MaintenanceState.java 36fea40

  ambari-server/src/main/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostImpl.java
9bdbd29 
  ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java
b3e7c8d 
  ambari-server/src/test/java/org/apache/ambari/server/controller/MaintenanceStateHelperTest.java
489499a 

Diff: https://reviews.apache.org/r/19707/diff/


Testing
-------

Results :

Tests run: 1513, Failures: 0, Errors: 0, Skipped: 10


Thanks,

Sid Wagle


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message