ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mahadev Konar" <maha...@apache.org>
Subject Re: Review Request 19682: hive-env.sh overwrites user value of HIVE_AUX_JARS_PATH
Date Wed, 26 Mar 2014 14:55:17 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19682/#review38607
-----------------------------------------------------------

Ship it!


Ship It!

- Mahadev Konar


On March 26, 2014, 1:57 p.m., Vitalyi Brodetskyi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19682/
> -----------------------------------------------------------
> 
> (Updated March 26, 2014, 1:57 p.m.)
> 
> 
> Review request for Ambari, Dmitro Lisnichenko and Mahadev Konar.
> 
> 
> Bugs: AMBARI-5223
>     https://issues.apache.org/jira/browse/AMBARI-5223
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> This line at the bottom of {{hive-env.sh}} disregards any user-provided values, masking
them from the launch script.
> 
> {noformat}
> # Folder containing extra ibraries required for hive compilation/execution can be controlled
by:
> export HIVE_AUX_JARS_PATH=/usr/lib/hcatalog/share/hcatalog/hcatalog-core.jar
> {noformat}
> 
> This breaks this feature for users of both the environment {{export HIVE_AUX_JARS_PATH="my
custom value"}} and the command line {{hive --auxpath "my custom value"}} .
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HIVE/package/templates/hive-env.sh.j2
548262a 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/package/templates/hive-env.sh.j2
61f8a60 
> 
> Diff: https://reviews.apache.org/r/19682/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message