ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sumit Mohanty" <smoha...@hortonworks.com>
Subject Re: Review Request 19654: stale_configs parameter works not properly after removing config group
Date Wed, 26 Mar 2014 00:11:51 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19654/#review38561
-----------------------------------------------------------

Ship it!


Ship It!

- Sumit Mohanty


On March 26, 2014, 12:02 a.m., Sid Wagle wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19654/
> -----------------------------------------------------------
> 
> (Updated March 26, 2014, 12:02 a.m.)
> 
> 
> Review request for Ambari, Mahadev Konar and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-5216
>     https://issues.apache.org/jira/browse/AMBARI-5216
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> *Steps:*
> # Deployed 3-node cluster.
> # Added new config group for HDFS service.
> # Assigned to newly created group 2 hosts.
> # Overrided property *DataNode maximum Java heap size* from value 1024 to 1025. 
> # Executed rolling restart of DataNodes so for them maxJavaHeapSize became to 1025. 
> # Removed newly created group and assigned to HDFS default (where maxJavaHeapSize is
1024).
> 
> *Result*: Restart indicator is absent for HDFS service after deleting config group with
custom property. 
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java
377471b 
>   ambari-server/src/main/java/org/apache/ambari/server/state/host/HostImpl.java 319b288

>   ambari-server/src/main/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostImpl.java
2e1480c 
>   ambari-server/src/test/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostTest.java
1a46442 
> 
> Diff: https://reviews.apache.org/r/19654/diff/
> 
> 
> Testing
> -------
> 
> Results :
> 
> Tests run: 1510, Failures: 0, Errors: 0, Skipped: 9
> 
> 
> Thanks,
> 
> Sid Wagle
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message