ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jaimin Jetly" <jaimin.je...@gmail.com>
Subject Review Request 19634: Ambari invalidates user names with underscore in it's value
Date Tue, 25 Mar 2014 20:59:08 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19634/
-----------------------------------------------------------

Review request for Ambari and Srimanth Gunturi.


Bugs: AMBARI-5214
    https://issues.apache.org/jira/browse/AMBARI-5214


Repository: ambari


Description
-------

Ambari imposes strict validation for standard user names. 
With this patch ambari will no longer impose strict validation on user name.
Although ambari will show warning for non-standard user names entered by the admin.


Diffs
-----

  ambari-web/app/data/service_configs.js a7dd0e9 
  ambari-web/app/messages.js 9c3ae98 
  ambari-web/app/models/form.js e301f09 
  ambari-web/app/models/service_config.js 791611d 
  ambari-web/app/models/user.js 1e96914 
  ambari-web/app/templates/main/admin/user/create.hbs cba744f 
  ambari-web/app/utils/configs/defaults_providers/user_defaults_provider.js PRE-CREATION 
  ambari-web/app/utils/configs/validators/tez_configs_validator.js 14042fb 
  ambari-web/app/utils/configs/validators/user_configs_validator.js PRE-CREATION 
  ambari-web/app/views/main/admin/user/create.js a533caa 

Diff: https://reviews.apache.org/r/19634/diff/


Testing
-------

Tested service config page on installer wizard(pre-installation) and Add local user page admin->user
(post-installation).


Thanks,

Jaimin Jetly


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message