ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dmytro Sen" <d...@hortonworks.com>
Subject Re: Review Request 19420: log4j configs to be applied after Ambari upgrade
Date Thu, 20 Mar 2014 16:37:30 GMT


> On March 19, 2014, 8:50 p.m., Sumit Mohanty wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog150.java,
line 719
> > <https://reviews.apache.org/r/19420/diff/1/?file=528404#file528404line719>
> >
> >     Why don't we hard code the types for which clusterconfigmapping entries need
to be created? 
> >     
> >     If you run upgrade twice what will happen?
> >     - add missing config will skip the configs and this is expected
> >     - will this mapping query also skip adding clusterconfigmapping entries?

The new patch correctly handles multiple run of "ambari-server upgrade" command.


- Dmytro


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19420/#review37794
-----------------------------------------------------------


On March 20, 2014, 4:22 p.m., Dmytro Sen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19420/
> -----------------------------------------------------------
> 
> (Updated March 20, 2014, 4:22 p.m.)
> 
> 
> Review request for Ambari, Myroslav Papirkovskyy and Sid Wagle.
> 
> 
> Bugs: AMBARI-5147
>     https://issues.apache.org/jira/browse/AMBARI-5147
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> As a part of ambari upgrade, customized log4j properties for HDP services must be imported
into *-log4j configs(hdfs-log4j, hbase-log4j, etc.). 
> Proposals:
> 1. "ambari-server upgrade" command runs separate java software, which connects to the
Ambari DB and creates required *-log4j configs. Admin should provide all log4j.properties
files, for instance, copy them to predefined directory on ambari-server node.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/upgrade/SchemaUpgradeHelper.java
b26091a 
>   ambari-server/src/main/java/org/apache/ambari/server/upgrade/StackUpgradeUtil.java
55697dc 
>   ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog150.java
3c1ad47 
>   ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog150Test.java
af2b247 
>   ambari-server/src/test/resources/stacks/HDP/1.3.4/services/HDFS/configuration/hdfs-log4j.xml
PRE-CREATION 
>   ambari-server/src/test/resources/stacks/HDP/1.3.4/services/HDFS/metainfo.xml 009acae

> 
> Diff: https://reviews.apache.org/r/19420/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dmytro Sen
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message