ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "John Speidel" <jspei...@hortonworks.com>
Subject Re: Review Request 19315: Allow cluster scoped configuration to be specified in blueprint
Date Mon, 17 Mar 2014 22:10:40 GMT


> On March 17, 2014, 8:11 p.m., Sid Wagle wrote:
> > BlueprintConfig and related schema changes need to updated in the UpgradeCatalog150.java
> 
> John Speidel wrote:
>     Thanks Sid.  I made the requested change in the new patch.
> 
> Sid Wagle wrote:
>     The FK constraint is missing from the UpgradeCatalog, rest looks good.
> 
> John Speidel wrote:
>     ok.  The reason that I didn't see this is that it looks like the blueprint related
fk's are all missing from the file currently.
> 
> Sid Wagle wrote:
>     Yes, you are right, seems to be an oversight, could you make it a part of this patch
?

included in patch 3.


- John


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19315/#review37453
-----------------------------------------------------------


On March 17, 2014, 10:09 p.m., John Speidel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19315/
> -----------------------------------------------------------
> 
> (Updated March 17, 2014, 10:09 p.m.)
> 
> 
> Review request for Ambari, Nate Cole, Sid Wagle, and Tom Beerbower.
> 
> 
> Bugs: AMBARI-5114
>     https://issues.apache.org/jira/browse/AMBARI-5114
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Enhance blueprint resource to allow cluster scoped configuration to be specified.  
> Host scoped configuration as well as the ability to export configuration information
from a running cluster will be added in subsequent patches.
> 
> This configuration information will end up in the cluster desired_configs.
> 
> {
>   "configurations" : [
>     {
>       "core-site" : {
>         "fs.trash.interval" : "480",
>         "ipc.client.idlethreshold" : "8500"
>       }
>     },
>     {
>       "mapred-site" : {
>         "tasktracker.http.threads" : "45"
>       }
>     }
>   ],
>   "host_groups" : [
>     {
>       "name" : "host_group_1",
>       "components" : [
>         {
>           "name" : "DATANODE"
>         },
>         {
>           "name" : "NAMENODE"
>         },
>         {
>           "name" : "JOBTRACKER"
>         },
>         {
>           "name" : "HISTORYSERVER"
>         },
>         {
>           "name" : "SECONDARY_NAMENODE"
>         },
>         {
>           "name" : "TASKTRACKER"
>         }
>       ],
>       "cardinality" : "1"
>     }
>   ],
>   "Blueprints" : {
>     "blueprint_name" : "single-node-test-with-cluster-config",
>     "stack_name" : "HDP",
>     "stack_version" : "1.3.3"
>   }
> }
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java dc13ab6

>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintResourceProvider.java
832f788 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterResourceProvider.java
1c79087 
>   ambari-server/src/main/java/org/apache/ambari/server/orm/entities/BlueprintConfigEntity.java
PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/orm/entities/BlueprintConfigEntityPK.java
PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/orm/entities/BlueprintEntity.java
9e89c86 
>   ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog150.java
6bcf381 
>   ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 0ca7859 
>   ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 1083e73 
>   ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 57c0558 
>   ambari-server/src/main/resources/META-INF/persistence.xml b6c1bd9 
>   ambari-server/src/main/resources/properties.json d2a949e 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintResourceProviderTest.java
4262f56 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClusterResourceProviderTest.java
a9ccd40 
>   ambari-server/src/test/java/org/apache/ambari/server/orm/entities/BlueprintConfigEntityPKTest.java
PRE-CREATION 
>   ambari-server/src/test/java/org/apache/ambari/server/orm/entities/BlueprintConfigEntityTest.java
PRE-CREATION 
>   ambari-server/src/test/java/org/apache/ambari/server/orm/entities/BlueprintEntityTest.java
994d548 
> 
> Diff: https://reviews.apache.org/r/19315/diff/
> 
> 
> Testing
> -------
> 
> Added new unit tests for new code.
> Ran all existing unit tests:
> OK
> ----------------------------------------------------------------------
> Total run:507
> Total errors:0
> Total failures:0
> ...
> [INFO] Executed tasks
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 20:00.033s
> [INFO] Finished at: Mon Mar 17 15:34:20 EDT 2014
> [INFO] Final Memory: 28M/123M
> [INFO] ------------------------------------------------------------------------
> 
> Functional testing:
> Created blueprints with and without configuration
> Created clusters from blueprints with and without configuration 
> 
> 
> Thanks,
> 
> John Speidel
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message