ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Vitalyi Brodetskyi" <vbrodets...@hortonworks.com>
Subject Review Request 19129: Proxied API requests do not return error details
Date Wed, 12 Mar 2014 16:27:58 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19129/
-----------------------------------------------------------

Review request for Ambari, Dmitro Lisnichenko and Nate Cole.


Bugs: AMBARI-5052
    https://issues.apache.org/jira/browse/AMBARI-5052


Repository: ambari


Description
-------

When invoking Falcon API directly, error messages are returned in the body.
{code}
[falcon@c6402 tmp]$ curl -i -uadmin:admin -d @dummy.xml -H 'Content-Type: text/xml' -X POST
'http://c6402.ambari.apache.org:15000/api/entities/submit/cluster?user.name=ambari-qa'
HTTP/1.1 400 Bad Request
Set-Cookie: hadoop.auth=u=ambari-qa&p=ambari-qa&t=simple&e=1394198276685&s=1Vktza5jyxYPcrpJVSDvok3lriQ=;
Path=/; Expires=Fri, 07-Mar-2014 13:17:56 GMT; HttpOnly
Content-Type: text/xml
Content-Length: 307
Server: Jetty(6.1.26)

<?xml version="1.0" encoding="UTF-8" standalone="yes"?><result><status>FAILED</status><message>Invalid
storage server or port: http://c6402.ambari.apache.org:11000/oozi
Exception creating FileSystem:No FileSystem for scheme: http</message><requestId>ec86dfbf-4e84-4909-8452-041c3c3f36c7</requestId></result>
{code}

When going through Ambari proxy, it only returns 400 Bad Request.
{code}
curl -i -uadmin:admin -d @dummy.xml -H 'Content-Type: text/xml' -X POST 'http://c6401.ambari.apache.org:8080/proxy?url=http://c6402.ambari.apache.org:15000/api/entities/submit/cluster?user.name=ambari-qa'
HTTP/1.1 400 Bad Request
Set-Cookie: AMBARISESSIONID=ypwgf9i05mrjajjcn0gk9gu1;Path=/
Content-Type: text/plain;charset=ISO-8859-1
Content-Length: 47
Server: Jetty(7.6.7.v20120910)

{
  "status": 400,
  "message": "Bad Request"
}
{code}


Diffs
-----

  ambari-server/src/main/java/org/apache/ambari/server/proxy/ProxyService.java cb07a0b 
  ambari-server/src/test/java/org/apache/ambari/server/proxy/ProxyServiceTest.java 9b824fd


Diff: https://reviews.apache.org/r/19129/diff/


Testing
-------

-------------------------------------------------------
 T E S T S
-------------------------------------------------------

-------------------------------------------------------
 T E S T S
-------------------------------------------------------
Listening for transport dt_socket at address: 5007
Running org.apache.ambari.server.proxy.ProxyServiceTest
Tests run: 8, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 89.416 sec

Results :

Tests run: 8, Failures: 0, Errors: 0, Skipped: 0


Thanks,

Vitalyi Brodetskyi


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message