ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dmytro Sen" <d...@hortonworks.com>
Subject Re: Review Request 19046: Lost heartbeat on host but ganglia shows a heartbeat lost
Date Tue, 11 Mar 2014 17:58:44 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19046/#review36818
-----------------------------------------------------------

Ship it!


Ship It!

- Dmytro Sen


On March 11, 2014, 3:54 p.m., Dmitro Lisnichenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19046/
> -----------------------------------------------------------
> 
> (Updated March 11, 2014, 3:54 p.m.)
> 
> 
> Review request for Ambari and Dmytro Sen.
> 
> 
> Bugs: AMBARI-5020
>     https://issues.apache.org/jira/browse/AMBARI-5020
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> The problem is that the code at org/apache/ambari/server/controller/internal/ServiceResourceProvider.java:886
(org.apache.ambari.server.controller.internal.ServiceResourceProvider.DefaultServiceState#getState)
relies on host component response order (it expects the master component to be listed at the
first place). Fixed that (and also the similar problem with slave components as well).
> 
> Also added a regression test that fails without my fixes.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ServiceResourceProvider.java
1e402eb 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ServiceResourceProviderTest.java
634c876 
> 
> Diff: https://reviews.apache.org/r/19046/diff/
> 
> 
> Testing
> -------
> 
> Unit test run and manual verification.
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Ambari Main ....................................... SUCCESS [0.416s]
> [INFO] Apache Ambari Project POM ......................... SUCCESS [0.038s]
> [INFO] Ambari Web ........................................ SUCCESS [5.404s]
> [INFO] Ambari Views ...................................... SUCCESS [2.851s]
> [INFO] Ambari Server ..................................... SUCCESS [11:57.258s]
> [INFO] Ambari Agent ...................................... SUCCESS [11.279s]
> [INFO] Ambari Client ..................................... SUCCESS [1.006s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 12:18.823s
> [INFO] Finished at: Tue Mar 11 18:50:49 FET 2014
> [INFO] Final Memory: 25M/224M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Dmitro Lisnichenko
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message