ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Vitaliy Semenyk" <vseme...@hortonworks.com>
Subject Re: Review Request 18732: [BUG-13267] Provide deb packages for Ambari server and Agents
Date Thu, 06 Mar 2014 16:31:47 GMT


> On March 5, 2014, 3:03 p.m., Dmitro Lisnichenko wrote:
> > ambari-agent/src/main/package/deb/control/control, line 1
> > <https://reviews.apache.org/r/18732/diff/1/?file=509484#file509484line1>
> >
> >     New file has no apache license prefix, mvn rat will fail. Please add header
to all new files

Fixed, but in compiled deb package these lines will be ignored, according to https://www.debian.org/doc/debian-policy/ch-controlfields.html


- Vitaliy


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18732/#review36225
-----------------------------------------------------------


On March 5, 2014, 1:21 p.m., Vitaliy Semenyk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18732/
> -----------------------------------------------------------
> 
> (Updated March 5, 2014, 1:21 p.m.)
> 
> 
> Review request for Ambari, Andrew Onischuk, Dmitro Lisnichenko, and Sid Wagle.
> 
> 
> Bugs: AMBARI-4934
>     https://issues.apache.org/jira/browse/AMBARI-4934
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Patch added:
>  pom.xml:
>    - new package goal "jdeb", which allows to build deb packages
>    - "deb.*" properties
>    - maven-resources-plugin for /usr/sbin/ambari-[agent|server] and version files (jdeb
supports only control files filtering)
>  general:
>    - debian control files (src/main/package/deb/control/*) and updated for Debian platform
post-installation, pre-installation scripts
> 
> Build command example: mvn package jdeb:jdeb
> 
> 
> Diffs
> -----
> 
>   .gitignore 246e53e 
>   ambari-agent/pom.xml 600d17d 
>   ambari-agent/src/main/package/deb/control/control PRE-CREATION 
>   ambari-agent/src/main/package/deb/control/postinst PRE-CREATION 
>   ambari-agent/src/main/package/deb/control/postrm PRE-CREATION 
>   ambari-agent/src/main/package/deb/control/posttrm PRE-CREATION 
>   ambari-agent/src/main/package/deb/control/preinst PRE-CREATION 
>   ambari-agent/src/main/package/deb/control/prerm PRE-CREATION 
>   ambari-client/pom.xml 1bd4c84 
>   ambari-client/src/main/package/deb/control/control PRE-CREATION 
>   ambari-client/src/main/package/deb/control/postinst PRE-CREATION 
>   ambari-client/src/main/package/deb/control/postrm PRE-CREATION 
>   ambari-client/src/main/package/deb/control/posttrm PRE-CREATION 
>   ambari-client/src/main/package/deb/control/preinst PRE-CREATION 
>   ambari-client/src/main/package/deb/control/prerm PRE-CREATION 
>   ambari-project/pom.xml 426a074 
>   ambari-project/src/main/package/deb/control/control PRE-CREATION 
>   ambari-project/src/main/package/deb/control/postinst PRE-CREATION 
>   ambari-project/src/main/package/deb/control/postrm PRE-CREATION 
>   ambari-project/src/main/package/deb/control/posttrm PRE-CREATION 
>   ambari-project/src/main/package/deb/control/preinst PRE-CREATION 
>   ambari-project/src/main/package/deb/control/prerm PRE-CREATION 
>   ambari-server/pom.xml 0da58d1 
>   ambari-server/src/main/package/deb/control/control PRE-CREATION 
>   ambari-server/src/main/package/deb/control/postinst PRE-CREATION 
>   ambari-server/src/main/package/deb/control/postrm PRE-CREATION 
>   ambari-server/src/main/package/deb/control/posttrm PRE-CREATION 
>   ambari-server/src/main/package/deb/control/preinst PRE-CREATION 
>   ambari-server/src/main/package/deb/control/prerm PRE-CREATION 
>   ambari-views/pom.xml 5adc775 
>   ambari-views/src/main/package/deb/control/control PRE-CREATION 
>   ambari-views/src/main/package/deb/control/postinst PRE-CREATION 
>   ambari-views/src/main/package/deb/control/postrm PRE-CREATION 
>   ambari-views/src/main/package/deb/control/posttrm PRE-CREATION 
>   ambari-views/src/main/package/deb/control/preinst PRE-CREATION 
>   ambari-views/src/main/package/deb/control/prerm PRE-CREATION 
>   ambari-web/pom.xml c01d558 
>   ambari-web/src/main/assemblies/empty.xml PRE-CREATION 
>   ambari-web/src/main/package/deb/control/control PRE-CREATION 
>   ambari-web/src/main/package/deb/control/postinst PRE-CREATION 
>   ambari-web/src/main/package/deb/control/postrm PRE-CREATION 
>   ambari-web/src/main/package/deb/control/posttrm PRE-CREATION 
>   ambari-web/src/main/package/deb/control/preinst PRE-CREATION 
>   ambari-web/src/main/package/deb/control/prerm PRE-CREATION 
>   pom.xml 33948b2 
>   src/main/assemblies/empty.xml PRE-CREATION 
>   src/main/package/deb/control/control PRE-CREATION 
>   src/main/package/deb/control/postinst PRE-CREATION 
>   src/main/package/deb/control/postrm PRE-CREATION 
>   src/main/package/deb/control/posttrm PRE-CREATION 
>   src/main/package/deb/control/preinst PRE-CREATION 
>   src/main/package/deb/control/prerm PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/18732/diff/
> 
> 
> Testing
> -------
> 
> was changed pom.xml files and bash scripts so unit-test are not required
> 
> 
> Thanks,
> 
> Vitaliy Semenyk
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message