ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andrew Onischuk" <aonis...@hortonworks.com>
Subject Re: Review Request 18732: [BUG-13267] Provide deb packages for Ambari server and Agents
Date Wed, 05 Mar 2014 13:28:23 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18732/#review36219
-----------------------------------------------------------



ambari-agent/pom.xml
<https://reviews.apache.org/r/18732/#comment67152>

    let's remove this '2.6' to single var, and reuse it for rpm and deb



ambari-agent/pom.xml
<https://reviews.apache.org/r/18732/#comment67153>

    think about how can we put this to a common var for rpm and deb not to make dublication



ambari-agent/src/main/package/deb/control/postinst
<https://reviews.apache.org/r/18732/#comment67154>

    also think can we move some common parts of the postinstall/preinstall scripts.



ambari-agent/src/main/package/deb/control/preinst
<https://reviews.apache.org/r/18732/#comment67150>

    We have already removed this 2 getent lines from the code due to some issues let's do
the same here.



pom.xml
<https://reviews.apache.org/r/18732/#comment67151>

    I don't think we can write our names here, think about some other publisher like Hortonworks


- Andrew Onischuk


On March 5, 2014, 1:21 p.m., Vitaliy Semenyk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18732/
> -----------------------------------------------------------
> 
> (Updated March 5, 2014, 1:21 p.m.)
> 
> 
> Review request for Ambari, Andrew Onischuk, Dmitro Lisnichenko, and Sid Wagle.
> 
> 
> Bugs: AMBARI-4934
>     https://issues.apache.org/jira/browse/AMBARI-4934
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Patch added:
>  pom.xml:
>    - new package goal "jdeb", which allows to build deb packages
>    - "deb.*" properties
>    - maven-resources-plugin for /usr/sbin/ambari-[agent|server] and version files (jdeb
supports only control files filtering)
>  general:
>    - debian control files (src/main/package/deb/control/*) and updated for Debian platform
post-installation, pre-installation scripts
> 
> Build command example: mvn package jdeb:jdeb
> 
> 
> Diffs
> -----
> 
>   .gitignore 246e53e 
>   ambari-agent/pom.xml 600d17d 
>   ambari-agent/src/main/package/deb/control/control PRE-CREATION 
>   ambari-agent/src/main/package/deb/control/postinst PRE-CREATION 
>   ambari-agent/src/main/package/deb/control/postrm PRE-CREATION 
>   ambari-agent/src/main/package/deb/control/posttrm PRE-CREATION 
>   ambari-agent/src/main/package/deb/control/preinst PRE-CREATION 
>   ambari-agent/src/main/package/deb/control/prerm PRE-CREATION 
>   ambari-client/pom.xml 1bd4c84 
>   ambari-client/src/main/package/deb/control/control PRE-CREATION 
>   ambari-client/src/main/package/deb/control/postinst PRE-CREATION 
>   ambari-client/src/main/package/deb/control/postrm PRE-CREATION 
>   ambari-client/src/main/package/deb/control/posttrm PRE-CREATION 
>   ambari-client/src/main/package/deb/control/preinst PRE-CREATION 
>   ambari-client/src/main/package/deb/control/prerm PRE-CREATION 
>   ambari-project/pom.xml 426a074 
>   ambari-project/src/main/package/deb/control/control PRE-CREATION 
>   ambari-project/src/main/package/deb/control/postinst PRE-CREATION 
>   ambari-project/src/main/package/deb/control/postrm PRE-CREATION 
>   ambari-project/src/main/package/deb/control/posttrm PRE-CREATION 
>   ambari-project/src/main/package/deb/control/preinst PRE-CREATION 
>   ambari-project/src/main/package/deb/control/prerm PRE-CREATION 
>   ambari-server/pom.xml 0da58d1 
>   ambari-server/src/main/package/deb/control/control PRE-CREATION 
>   ambari-server/src/main/package/deb/control/postinst PRE-CREATION 
>   ambari-server/src/main/package/deb/control/postrm PRE-CREATION 
>   ambari-server/src/main/package/deb/control/posttrm PRE-CREATION 
>   ambari-server/src/main/package/deb/control/preinst PRE-CREATION 
>   ambari-server/src/main/package/deb/control/prerm PRE-CREATION 
>   ambari-views/pom.xml 5adc775 
>   ambari-views/src/main/package/deb/control/control PRE-CREATION 
>   ambari-views/src/main/package/deb/control/postinst PRE-CREATION 
>   ambari-views/src/main/package/deb/control/postrm PRE-CREATION 
>   ambari-views/src/main/package/deb/control/posttrm PRE-CREATION 
>   ambari-views/src/main/package/deb/control/preinst PRE-CREATION 
>   ambari-views/src/main/package/deb/control/prerm PRE-CREATION 
>   ambari-web/pom.xml c01d558 
>   ambari-web/src/main/assemblies/empty.xml PRE-CREATION 
>   ambari-web/src/main/package/deb/control/control PRE-CREATION 
>   ambari-web/src/main/package/deb/control/postinst PRE-CREATION 
>   ambari-web/src/main/package/deb/control/postrm PRE-CREATION 
>   ambari-web/src/main/package/deb/control/posttrm PRE-CREATION 
>   ambari-web/src/main/package/deb/control/preinst PRE-CREATION 
>   ambari-web/src/main/package/deb/control/prerm PRE-CREATION 
>   pom.xml 33948b2 
>   src/main/assemblies/empty.xml PRE-CREATION 
>   src/main/package/deb/control/control PRE-CREATION 
>   src/main/package/deb/control/postinst PRE-CREATION 
>   src/main/package/deb/control/postrm PRE-CREATION 
>   src/main/package/deb/control/posttrm PRE-CREATION 
>   src/main/package/deb/control/preinst PRE-CREATION 
>   src/main/package/deb/control/prerm PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/18732/diff/
> 
> 
> Testing
> -------
> 
> was changed pom.xml files and bash scripts so unit-test are not required
> 
> 
> Thanks,
> 
> Vitaliy Semenyk
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message