ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tom Beerbower" <tbeerbo...@hortonworks.com>
Subject Re: Review Request 18737: Configs are not applied if site has empty properties
Date Tue, 04 Mar 2014 18:16:12 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18737/#review36126
-----------------------------------------------------------


Just curious... would it be bad to allow an empty config if there was no previous version?
 I'm not sure why you have that restriction.  Isn't an empty config the same as no config
for that type?

- Tom Beerbower


On March 4, 2014, 6:02 p.m., Nate Cole wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18737/
> -----------------------------------------------------------
> 
> (Updated March 4, 2014, 6:02 p.m.)
> 
> 
> Review request for Ambari, Sid Wagle and Tom Beerbower.
> 
> 
> Bugs: AMBARI-4938
>     https://issues.apache.org/jira/browse/AMBARI-4938
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> * Allow empty configs to be set, only if there was a previous version for the same type.
> * Fix zookeeper stale flag since I was testing ZK to start with.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
10d07b6 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/ZOOKEEPER/metainfo.xml 3e048a6

>   ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java
dcee4bf 
> 
> Diff: https://reviews.apache.org/r/18737/diff/
> 
> 
> Testing
> -------
> 
> Running org.apache.ambari.server.controller.AmbariManagementControllerTest
> Tests run: 106, Failures: 0, Errors: 0, Skipped: 6, Time elapsed: 129.642 sec
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 12:58.517s
> [INFO] Finished at: Tue Mar 04 13:01:08 EST 2014
> [INFO] Final Memory: 18M/123M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Nate Cole
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message