Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@ambari.apache.org
Content-Type: multipart/alternative;
 boundary="===============7461835573427423247=="
MIME-Version: 1.0
Subject: Re: Review Request 18640: Allow upgrade stack to take a url as
 parameter for
 a local repo change.
From: "Sid Wagle" <swagle@hortonworks.com>
To: "Sumit Mohanty" <smohanty@hortonworks.com>,
 "Sid Wagle" <swagle@hortonworks.com>
Cc: "Nate Cole" <ncole@hortonworks.com>, "Ambari" <dev@ambari.apache.org>
Date: Fri, 28 Feb 2014 20:40:14 -0000
Message-ID: <20140228204014.8005.58127@reviews.apache.org>
Auto-Submitted: auto-generated
Sender: "Sid Wagle" <noreply@reviews.apache.org>
References: <20140228203355.8005.82221@reviews.apache.org>
In-Reply-To: <20140228203355.8005.82221@reviews.apache.org>
Reply-To: "Sid Wagle" <swagle@hortonworks.com>

--===============7461835573427423247==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18640/#review35839
-----------------------------------------------------------

Ship it!


Ship It!

- Sid Wagle


On Feb. 28, 2014, 8:33 p.m., Nate Cole wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18640/
> -----------------------------------------------------------
> 
> (Updated Feb. 28, 2014, 8:33 p.m.)
> 
> 
> Review request for Ambari, Sumit Mohanty and Sid Wagle.
> 
> 
> Bugs: AMBARI-4894
>     https://issues.apache.org/jira/browse/AMBARI-4894
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Added two optional parameters to ambari-server upgradestack:
> 1. The URL for local repo.
> 2. A possible csv of os types to apply it to.  If you don't provide that, there is no way to know which repo url it's for (centos5, centos6?)  If that parameter is omitted, apply the URL to all repos.
> 3. Added tests.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/upgrade/StackUpgradeHelper.java b9fec20 
>   ambari-server/src/main/java/org/apache/ambari/server/upgrade/StackUpgradeUtil.java 75189cc 
>   ambari-server/src/main/python/ambari-server.py 30b778c 
>   ambari-server/src/test/java/org/apache/ambari/server/upgrade/StackUpgradeUtilTest.java PRE-CREATION 
>   ambari-server/src/test/python/TestAmbariServer.py d1053aa 
> 
> Diff: https://reviews.apache.org/r/18640/diff/
> 
> 
> Testing
> -------
> 
> Java:
> Results :
> 
> Tests run: 1476, Failures: 0, Errors: 0, Skipped: 9
> 
> Python:
> test_run_stack_upgrade (TestAmbariServer.TestAmbariServer) ... ok
> test_run_stack_upgrade_with_url (TestAmbariServer.TestAmbariServer) ... ok
> test_run_stack_upgrade_with_url_os (TestAmbariServer.TestAmbariServer) ... ok
> 
> Overall:
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 13:06.282s
> [INFO] Finished at: Fri Feb 28 15:17:55 EST 2014
> [INFO] Final Memory: 18M/123M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Nate Cole
> 
>


--===============7461835573427423247==--