Return-Path: 
 <dev-return-24282-apmail-ambari-dev-archive=ambari.apache.org@ambari.apache.org>
X-Original-To: apmail-ambari-dev-archive@www.apache.org
Delivered-To: apmail-ambari-dev-archive@www.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id E5DD4100A4
	for <apmail-ambari-dev-archive@www.apache.org>;
 Thu, 27 Feb 2014 13:52:20 +0000 (UTC)
Received: (qmail 936 invoked by uid 500); 27 Feb 2014 13:52:20 -0000
Delivered-To: apmail-ambari-dev-archive@ambari.apache.org
Received: (qmail 858 invoked by uid 500); 27 Feb 2014 13:52:19 -0000
Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@ambari.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@ambari.apache.org>
List-Post: <mailto:dev@ambari.apache.org>
List-Id: <dev.ambari.apache.org>
Reply-To: dev@ambari.apache.org
Delivered-To: mailing list dev@ambari.apache.org
Received: (qmail 824 invoked by uid 99); 27 Feb 2014 13:52:17 -0000
Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40)
    by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 27 Feb 2014 13:52:17 +0000
Received: from reviews.apache.org (localhost [127.0.0.1])
	by reviews.apache.org (Postfix) with ESMTP id 587A11C0036;
	Thu, 27 Feb 2014 13:52:16 +0000 (UTC)
Content-Type: multipart/alternative;
 boundary="===============8150479497972504699=="
MIME-Version: 1.0
Subject: Re: Review Request 18561: Ambari Views : Allow headers to be passed
 to View
 URLStreamProvider
From: "Nate Cole" <ncole@hortonworks.com>
To: "Nate Cole" <ncole@hortonworks.com>
Cc: "Ambari" <dev@ambari.apache.org>,
 "Tom Beerbower" <tbeerbower@hortonworks.com>
Date: Thu, 27 Feb 2014 13:52:15 -0000
Message-ID: <20140227135215.19085.26576@reviews.apache.org>
X-ReviewBoard-URL: https://reviews.apache.org
Auto-Submitted: auto-generated
Sender: "Nate Cole" <noreply@reviews.apache.org>
X-ReviewGroup: Ambari
X-ReviewRequest-URL: https://reviews.apache.org/r/18561/
X-Sender: "Nate Cole" <noreply@reviews.apache.org>
References: <20140227113127.9913.63663@reviews.apache.org>
In-Reply-To: <20140227113127.9913.63663@reviews.apache.org>
Reply-To: "Nate Cole" <ncole@hortonworks.com>
X-ReviewRequest-Repository: ambari

--===============8150479497972504699==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18561/#review35621
-----------------------------------------------------------

Ship it!


Ship It!

- Nate Cole


On Feb. 27, 2014, 6:31 a.m., Tom Beerbower wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18561/
> -----------------------------------------------------------
> 
> (Updated Feb. 27, 2014, 6:31 a.m.)
> 
> 
> Review request for Ambari and Nate Cole.
> 
> 
> Bugs: AMBARI-4863
>     https://issues.apache.org/jira/browse/AMBARI-4863
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Add ability to pass headers to org.apache.ambari.view.URLStreamProvider.
> 
> {code}
>   /**
>    * Read from the input stream specified by the given URL spec.
>    *
>    * @param spec           the String to parse as a URL
>    * @param requestMethod  the HTTP method (GET,POST,PUT,etc.).
>    * @param params         the body of the request; may be null
>    * @param headers        the headers of the request; may be null
>    *
>    * @return the input stream
>    *
>    * @throws IOException if an error occurred connecting to the server
>    */
>   public InputStream readFrom(String spec, String requestMethod, String params, Map<String, List<String>> headers)
>       throws IOException;
> {code}
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/view/ViewContextImpl.java 95f47f4 
>   ambari-server/src/test/java/org/apache/ambari/server/view/ViewContextImplTest.java 7422393 
>   ambari-views/src/main/java/org/apache/ambari/view/URLStreamProvider.java 78c9d12 
> 
> Diff: https://reviews.apache.org/r/18561/diff/
> 
> 
> Testing
> -------
> 
> Added new unit tests.
> 
> All existing unit tests pass :
> 
> Results :
> 
> Tests run: 1420, Failures: 0, Errors: 0, Skipped: 11
> 
> 
> Thanks,
> 
> Tom Beerbower
> 
>


--===============8150479497972504699==--