Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@ambari.apache.org
Content-Type: multipart/alternative;
 boundary="===============3774011498925321860=="
MIME-Version: 1.0
Subject: Re: Review Request 18312: A single API call to toggle Maintenance
 Mode for
 multiple hosts is creating multiple requests
From: "Tom Beerbower" <tbeerbower@hortonworks.com>
To: "Tom Beerbower" <tbeerbower@hortonworks.com>
Cc: "Nate Cole" <ncole@hortonworks.com>, "Ambari" <dev@ambari.apache.org>
Date: Thu, 20 Feb 2014 18:05:06 -0000
Message-ID: <20140220180506.19403.16064@reviews.apache.org>
Auto-Submitted: auto-generated
Sender: "Tom Beerbower" <noreply@reviews.apache.org>
References: <20140220162349.29785.91649@reviews.apache.org>
In-Reply-To: <20140220162349.29785.91649@reviews.apache.org>
Reply-To: "Tom Beerbower" <tbeerbower@hortonworks.com>

--===============3774011498925321860==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18312/#review35016
-----------------------------------------------------------


Was the test failing before your changes or because of them?  If it's failing because of them, do you think that the test is bogus?  If so, I would completely remove the test instead of ignoring it.  Also, if you are going to @Ignore a test I would add the annotation to the @Test annotation instead of replacing it.

- Tom Beerbower


On Feb. 20, 2014, 4:23 p.m., Nate Cole wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18312/
> -----------------------------------------------------------
> 
> (Updated Feb. 20, 2014, 4:23 p.m.)
> 
> 
> Review request for Ambari and Tom Beerbower.
> 
> 
> Bugs: AMBARI-4761
>     https://issues.apache.org/jira/browse/AMBARI-4761
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Small change to collect cluster names for maintenance state, then issue only one command, instead of one-per-change.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java d607eb4 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/PassiveStateHelper.java 4d412f7 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostResourceProvider.java 01163b7 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ServiceResourceProvider.java 9cbd16f 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java 2a1cf20 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/PassiveStateHelperTest.java 8b4ad30 
> 
> Diff: https://reviews.apache.org/r/18312/diff/
> 
> 
> Testing
> -------
> 
> * Marked @Ignore on failing test in AmbariManagementControllerTest
> * Added test scenarios for multiple hosts
> 
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 12:57.340s
> [INFO] Finished at: Thu Feb 20 10:39:21 EST 2014
> [INFO] Final Memory: 18M/123M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Nate Cole
> 
>


--===============3774011498925321860==--