Return-Path: X-Original-To: apmail-ambari-dev-archive@www.apache.org Delivered-To: apmail-ambari-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id EF2E210334 for ; Thu, 20 Feb 2014 05:21:19 +0000 (UTC) Received: (qmail 26965 invoked by uid 500); 20 Feb 2014 05:21:08 -0000 Delivered-To: apmail-ambari-dev-archive@ambari.apache.org Received: (qmail 26862 invoked by uid 500); 20 Feb 2014 05:21:06 -0000 Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ambari.apache.org Delivered-To: mailing list dev@ambari.apache.org Received: (qmail 26789 invoked by uid 99); 20 Feb 2014 05:21:04 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 20 Feb 2014 05:21:04 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 83BF71D48E9; Thu, 20 Feb 2014 05:21:04 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============2331613587664400730==" MIME-Version: 1.0 Subject: Re: Review Request 18301: Failure tolerance parameter doesn't seem to work for Rolling Restarts From: "Sumit Mohanty" To: "Mahadev Konar" , "Myroslav Papirkovskyy" , "Sumit Mohanty" Cc: "Sid Wagle" , "Ambari" Date: Thu, 20 Feb 2014 05:21:04 -0000 Message-ID: <20140220052104.29785.37124@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Sumit Mohanty" X-ReviewGroup: Ambari X-ReviewRequest-URL: https://reviews.apache.org/r/18301/ X-Sender: "Sumit Mohanty" References: <20140220050241.4362.46187@reviews.apache.org> In-Reply-To: <20140220050241.4362.46187@reviews.apache.org> Reply-To: "Sumit Mohanty" X-ReviewRequest-Repository: ambari --===============2331613587664400730== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18301/#review34984 ----------------------------------------------------------- Ship it! Minor comments: ambari-server/src/main/java/org/apache/ambari/server/scheduler/ExecutionScheduleManager.java Do we need the "import org.quartz.JobDataMap;"? Why does addTaskCountToProperties() need explicit throws ? - Sumit Mohanty On Feb. 20, 2014, 5:02 a.m., Sid Wagle wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/18301/ > ----------------------------------------------------------- > > (Updated Feb. 20, 2014, 5:02 a.m.) > > > Review request for Ambari, Mahadev Konar, Myroslav Papirkovskyy, and Sumit Mohanty. > > > Bugs: AMBARI-4758 > https://issues.apache.org/jira/browse/AMBARI-4758 > > > Repository: ambari > > > Description > ------- > > Trigger rolling restart with failure tolerance set to 1. > Induce a fail of restart operation somehow on the component, being restarted. > > Result: batches are scheduled after the first operation fails. > > > Diffs > ----- > > ambari-server/src/main/java/org/apache/ambari/server/scheduler/AbstractLinearExecutionJob.java d4602a2 > ambari-server/src/main/java/org/apache/ambari/server/scheduler/ExecutionScheduleManager.java ef8dc9d > ambari-server/src/main/java/org/apache/ambari/server/state/scheduler/BatchRequestJob.java 0718dcc > ambari-server/src/test/java/org/apache/ambari/server/state/scheduler/BatchRequestJobTest.java 7ed183f > > Diff: https://reviews.apache.org/r/18301/diff/ > > > Testing > ------- > > > Thanks, > > Sid Wagle > > --===============2331613587664400730==--