Return-Path: X-Original-To: apmail-ambari-dev-archive@www.apache.org Delivered-To: apmail-ambari-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 73A48106D4 for ; Tue, 18 Feb 2014 15:52:56 +0000 (UTC) Received: (qmail 41879 invoked by uid 500); 18 Feb 2014 15:52:56 -0000 Delivered-To: apmail-ambari-dev-archive@ambari.apache.org Received: (qmail 41858 invoked by uid 500); 18 Feb 2014 15:52:55 -0000 Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ambari.apache.org Delivered-To: mailing list dev@ambari.apache.org Received: (qmail 41847 invoked by uid 99); 18 Feb 2014 15:52:53 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 18 Feb 2014 15:52:53 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 5730D1C00F6; Tue, 18 Feb 2014 15:52:53 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============3932279893404434119==" MIME-Version: 1.0 Subject: Review Request 18215: Hive Metastore alerts still shows in UI when Hive is in Maint. Mode From: "Nate Cole" To: "Sid Wagle" , "Tom Beerbower" Cc: "Ambari" , "Nate Cole" Date: Tue, 18 Feb 2014 15:52:53 -0000 Message-ID: <20140218155253.4367.95045@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Nate Cole" X-ReviewGroup: Ambari X-ReviewRequest-URL: https://reviews.apache.org/r/18215/ X-Sender: "Nate Cole" Reply-To: "Nate Cole" X-ReviewRequest-Repository: ambari --===============3932279893404434119== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18215/ ----------------------------------------------------------- Review request for Ambari, Sid Wagle and Tom Beerbower. Bugs: AMBARI-4712 https://issues.apache.org/jira/browse/AMBARI-4712 Repository: ambari Description ------- * Hive service/component name not taken into account * Hive status check puts the whole stack trace, leaving key information at the end Diffs ----- ambari-server/src/main/java/org/apache/ambari/server/controller/nagios/NagiosPropertyProvider.java a57c87b ambari-server/src/main/resources/stacks/HDP/1.3.2/services/NAGIOS/package/files/check_wrapper.sh ece44b2 ambari-server/src/main/resources/stacks/HDP/2.0.6/services/NAGIOS/package/files/check_wrapper.sh a1b6a12 ambari-server/src/test/java/org/apache/ambari/server/controller/nagios/NagiosPropertyProviderTest.java 209e04a ambari-server/src/test/resources/nagios_alerts.txt a90f445 Diff: https://reviews.apache.org/r/18215/diff/ Testing ------- Added test case for "complex" Hive error output. No tests for check_wrapper.sh (we don't have any tests for Nagios plugins) Thanks, Nate Cole --===============3932279893404434119==--