Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@ambari.apache.org
Content-Type: multipart/alternative;
 boundary="===============3851943228971072579=="
MIME-Version: 1.0
Subject: Re: Review Request 17903: Various issues related to decommission
 support
From: "Sid Wagle" <swagle@hortonworks.com>
To: "Andrew Onischuk" <aonishuk@hortonworks.com>,
 "Sid Wagle" <swagle@hortonworks.com>
Cc: "Sumit Mohanty" <smohanty@hortonworks.com>,
 "Ambari" <dev@ambari.apache.org>
Date: Mon, 10 Feb 2014 21:57:51 -0000
Message-ID: <20140210215751.29251.60603@reviews.apache.org>
Auto-Submitted: auto-generated
Sender: "Sid Wagle" <noreply@reviews.apache.org>
References: <20140210182142.29251.16111@reviews.apache.org>
In-Reply-To: <20140210182142.29251.16111@reviews.apache.org>
Reply-To: "Sid Wagle" <swagle@hortonworks.com>

--===============3851943228971072579==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17903/#review34113
-----------------------------------------------------------

Ship it!


Ship It!

- Sid Wagle


On Feb. 10, 2014, 6:21 p.m., Sumit Mohanty wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17903/
> -----------------------------------------------------------
> 
> (Updated Feb. 10, 2014, 6:21 p.m.)
> 
> 
> Review request for Ambari, Andrew Onischuk and Sid Wagle.
> 
> 
> Bugs: AMBARI-4570
>     https://issues.apache.org/jira/browse/AMBARI-4570
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Tracking few issues related to decommission support
> Even with HBase HA only one master should be used for decommission
> Alternatively, for HDFS/MR/YARN use all master host components
> Do not use "default" method while using python based system resources
> Add support for command details and custom command names
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/actionmanager/HostRoleCommand.java 127feab 
>   ambari-server/src/main/java/org/apache/ambari/server/actionmanager/Stage.java 0024e53 
>   ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java ac284b3 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java 602bf57 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/ShortTaskStatus.java 66a65d3 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/TaskStatusResponse.java 192cad4 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/TaskResourceProvider.java b533a1f 
>   ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostRoleCommandEntity.java 61b4f5f 
>   ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql c9b4bdb 
>   ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql ed2305b 
>   ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 6bc6f24 
>   ambari-server/src/main/resources/properties.json f453e0d 
>   ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HBASE/package/scripts/params.py 5c6576a 
>   ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HDFS/package/scripts/hdfs_namenode.py d8e191f 
>   ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HDFS/package/scripts/params.py 7ec0a88 
>   ambari-server/src/main/resources/stacks/HDP/1.3.2/services/MAPREDUCE/package/scripts/jobtracker.py 5cd41ae 
>   ambari-server/src/main/resources/stacks/HDP/1.3.2/services/MAPREDUCE/package/scripts/params.py d722124 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HBASE/package/scripts/params.py 5e156cd 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/hdfs_namenode.py 8b29cc3 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/params.py 99fdc70 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/package/scripts/params.py 631c3a8 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/package/scripts/resourcemanager.py 0540670 
>   ambari-server/src/main/resources/upgrade/ddl/Ambari-DDL-MySQL-UPGRADE.sql c12aa82 
>   ambari-server/src/main/resources/upgrade/ddl/Ambari-DDL-Oracle-UPGRADE.sql b82f4e8 
>   ambari-server/src/main/resources/upgrade/ddl/Ambari-DDL-Postgres-UPGRADE-1.3.0.sql 01bf43b 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java 5bea305 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/TaskResourceProviderTest.java 4a8c325 
>   ambari-server/src/test/python/stacks/1.3.2/MAPREDUCE/test_mapreduce_jobtracker.py 4c442ad 
>   ambari-server/src/test/python/stacks/1.3.2/configs/default.hbasedecom.json 6d12470 
>   ambari-server/src/test/python/stacks/1.3.2/configs/default.json a4d74c3 
>   ambari-server/src/test/python/stacks/1.3.2/configs/secured.json 3f19af8 
>   ambari-server/src/test/python/stacks/2.0.6/configs/default.json 611645e 
>   ambari-server/src/test/python/stacks/2.0.6/configs/secured.json e10f4ee 
> 
> Diff: https://reviews.apache.org/r/17903/diff/
> 
> 
> Testing
> -------
> 
> Results (with some known failures):
> 
> Failed tests:   testActionTimeout(org.apache.ambari.server.actionmanager.TestActionScheduler): (..)
> 
> Tests run: 1397, Failures: 1, Errors: 0, Skipped: 7
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Ambari Main ....................................... SUCCESS [0.744s]
> [INFO] Apache Ambari Project POM ......................... SUCCESS [0.243s]
> [INFO] Ambari Server ..................................... FAILURE [12:27.720s]
> 
> ======================================================================
> FAIL: test_install_packages (TestScript.TestScript)
> ----------------------------------------------------------------------
> Traceback (most recent call last):
>   File "/Users/smohanty/enlistments/asf-ambari/ambari-common/src/test/python/mock/mock.py", line 1199, in patched
>     return func(*args, **keywargs)
>   File "/Users/smohanty/enlistments/asf-ambari/ambari-agent/src/test/python/resource_management/TestScript.py", line 76, in test_install_packages
>     self.assertEquals(resource_dump, "[Repository['HDP-2.0._'], Repository['HDP-2.0._']]")
> AssertionError: "[Repository['HDP-2.0._']]" != "[Repository['HDP-2.0._'], Repository['HDP-2.0._']]"
> 
> ----------------------------------------------------------------------
> Ran 237 tests in 10.245s
> 
> FAILED (failures=1)
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Ambari Agent ...................................... FAILURE [14.867s]
> 
> 
> Thanks,
> 
> Sumit Mohanty
> 
>


--===============3851943228971072579==--