ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tom Beerbower" <tbeerbo...@hortonworks.com>
Subject Re: Review Request 18561: Ambari Views : Allow headers to be passed to View URLStreamProvider
Date Thu, 27 Feb 2014 11:31:27 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18561/
-----------------------------------------------------------

(Updated Feb. 27, 2014, 11:31 a.m.)


Review request for Ambari and Nate Cole.


Bugs: AMBARI-4863
    https://issues.apache.org/jira/browse/AMBARI-4863


Repository: ambari


Description
-------

Add ability to pass headers to org.apache.ambari.view.URLStreamProvider.

{code}
  /**
   * Read from the input stream specified by the given URL spec.
   *
   * @param spec           the String to parse as a URL
   * @param requestMethod  the HTTP method (GET,POST,PUT,etc.).
   * @param params         the body of the request; may be null
   * @param headers        the headers of the request; may be null
   *
   * @return the input stream
   *
   * @throws IOException if an error occurred connecting to the server
   */
  public InputStream readFrom(String spec, String requestMethod, String params, Map<String,
List<String>> headers)
      throws IOException;
{code}


Diffs (updated)
-----

  ambari-server/src/main/java/org/apache/ambari/server/view/ViewContextImpl.java 95f47f4 
  ambari-server/src/test/java/org/apache/ambari/server/view/ViewContextImplTest.java 7422393

  ambari-views/src/main/java/org/apache/ambari/view/URLStreamProvider.java 78c9d12 

Diff: https://reviews.apache.org/r/18561/diff/


Testing
-------

Added new unit tests.

All existing unit tests pass :

Results :

Tests run: 1420, Failures: 0, Errors: 0, Skipped: 11


Thanks,

Tom Beerbower


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message