ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Nate Cole" <nc...@hortonworks.com>
Subject Review Request 18312: A single API call to toggle Maintenance Mode for multiple hosts is creating multiple requests
Date Thu, 20 Feb 2014 16:23:49 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18312/
-----------------------------------------------------------

Review request for Ambari and Tom Beerbower.


Bugs: AMBARI-4761
    https://issues.apache.org/jira/browse/AMBARI-4761


Repository: ambari


Description
-------

Small change to collect cluster names for maintenance state, then issue only one command,
instead of one-per-change.


Diffs
-----

  ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
d607eb4 
  ambari-server/src/main/java/org/apache/ambari/server/controller/PassiveStateHelper.java
4d412f7 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostResourceProvider.java
01163b7 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ServiceResourceProvider.java
9cbd16f 
  ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java
2a1cf20 
  ambari-server/src/test/java/org/apache/ambari/server/controller/PassiveStateHelperTest.java
8b4ad30 

Diff: https://reviews.apache.org/r/18312/diff/


Testing
-------

* Marked @Ignore on failing test in AmbariManagementControllerTest
* Added test scenarios for multiple hosts


[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 12:57.340s
[INFO] Finished at: Thu Feb 20 10:39:21 EST 2014
[INFO] Final Memory: 18M/123M
[INFO] ------------------------------------------------------------------------


Thanks,

Nate Cole


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message