ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sumit Mohanty" <smoha...@hortonworks.com>
Subject Re: Review Request 18301: Failure tolerance parameter doesn't seem to work for Rolling Restarts
Date Thu, 20 Feb 2014 05:21:04 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18301/#review34984
-----------------------------------------------------------

Ship it!


Minor comments:

ambari-server/src/main/java/org/apache/ambari/server/scheduler/ExecutionScheduleManager.java
Do we need the "import org.quartz.JobDataMap;"?

Why does addTaskCountToProperties() need explicit throws ?


- Sumit Mohanty


On Feb. 20, 2014, 5:02 a.m., Sid Wagle wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18301/
> -----------------------------------------------------------
> 
> (Updated Feb. 20, 2014, 5:02 a.m.)
> 
> 
> Review request for Ambari, Mahadev Konar, Myroslav Papirkovskyy, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-4758
>     https://issues.apache.org/jira/browse/AMBARI-4758
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Trigger rolling restart with failure tolerance set to 1.
> Induce a fail of restart operation somehow on the component, being restarted.
> 
> Result: batches are scheduled after the first operation fails.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/scheduler/AbstractLinearExecutionJob.java
d4602a2 
>   ambari-server/src/main/java/org/apache/ambari/server/scheduler/ExecutionScheduleManager.java
ef8dc9d 
>   ambari-server/src/main/java/org/apache/ambari/server/state/scheduler/BatchRequestJob.java
0718dcc 
>   ambari-server/src/test/java/org/apache/ambari/server/state/scheduler/BatchRequestJobTest.java
7ed183f 
> 
> Diff: https://reviews.apache.org/r/18301/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sid Wagle
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message