ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dmitro Lisnichenko" <dlysniche...@hortonworks.com>
Subject Re: Review Request 18082: Prevent deleting all users
Date Thu, 13 Feb 2014 16:58:33 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18082/#review34381
-----------------------------------------------------------

Ship it!


Ship It!

- Dmitro Lisnichenko


On Feb. 13, 2014, 4:19 p.m., Dmytro Shkvyra wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18082/
> -----------------------------------------------------------
> 
> (Updated Feb. 13, 2014, 4:19 p.m.)
> 
> 
> Review request for Ambari, Dmitro Lisnichenko and Myroslav Papirkovskyy.
> 
> 
> Bugs: AMBARI-4653
>     https://issues.apache.org/jira/browse/AMBARI-4653
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Patch is check if user which should be deleted is last user with admin role. Also, it
check if we remove admin role from user, this user should not be last user with admin role.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/orm/dao/UserDAO.java 89c9cd8 
>   ambari-server/src/main/java/org/apache/ambari/server/security/authorization/Users.java
90ee80c 
>   ambari-server/src/test/java/org/apache/ambari/server/orm/dao/UserDAOTest.java PRE-CREATION

>   ambari-server/src/test/java/org/apache/ambari/server/security/authorization/TestUsers.java
1d660b5 
> 
> Diff: https://reviews.apache.org/r/18082/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dmytro Shkvyra
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message