ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dmitro Lisnichenko" <dlysniche...@hortonworks.com>
Subject Re: Review Request 18015: Passthrough /proxy API not passing through extra params
Date Wed, 12 Feb 2014 15:56:13 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18015/#review34289
-----------------------------------------------------------

Ship it!


Ship It!

- Dmitro Lisnichenko


On Feb. 12, 2014, 3:46 p.m., Vitalyi Brodetskyi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18015/
> -----------------------------------------------------------
> 
> (Updated Feb. 12, 2014, 3:46 p.m.)
> 
> 
> Review request for Ambari, Dmitro Lisnichenko and Nate Cole.
> 
> 
> Bugs: AMBARI-4630
>     https://issues.apache.org/jira/browse/AMBARI-4630
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> UI makes the following call where there are multiple params which should end up in the
target URL
> 
> /proxy?url=http://server:8188/ws/v1/apptimeline/HIVE_QUERY_ID?fields=events,primaryfilters&limit=10&primaryFilter=user:hiveuser1
> 
> 
> None of the filter params (fields, limit, primaryFilter) are ending up on the target
server. The passthrough API should pass through all extra params (other than url). 
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/URLStreamProvider.java
be95221 
>   ambari-server/src/main/java/org/apache/ambari/server/proxy/ProxyService.java 3ed0b8c

>   ambari-server/src/test/java/org/apache/ambari/server/proxy/ProxyServiceTest.java 1a9a176

> 
> Diff: https://reviews.apache.org/r/18015/diff/
> 
> 
> Testing
> -------
> 
> -------------------------------------------------------
>  T E S T S
> -------------------------------------------------------
> Listening for transport dt_socket at address: 5006
> Running org.apache.ambari.server.proxy.ProxyServiceTest
> Tests run: 7, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 8.34 sec
> 
> Results :
> 
> Tests run: 7, Failures: 0, Errors: 0, Skipped: 0
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message