ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sumit Mohanty" <smoha...@hortonworks.com>
Subject Re: Review Request 17668: ZooKeeper services need to be started first and running prior to starting HDFS in a HA Environment.
Date Wed, 05 Feb 2014 19:18:48 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17668/#review33705
-----------------------------------------------------------


Got it. Thanks for the explanation.

ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ServiceResourceProvider.java
* import org.apache.ambari.server.*; -- can you expand it back


ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ServiceResourceProviderTest.java
* import static org.easymock.EasyMock.* -- same as above

Can you add a unit test for "getTransitiveServices"?

There is one scenario about which I am a little concerned. Let me know if its correct.

Now, if we start any service, it will look for the dependencies and then start them. For example,
OOZIE start will start MR, HDFS etc. Is this correct? If yes should we allow that?

- Sumit Mohanty


On Feb. 3, 2014, 6:49 p.m., Dmytro Sen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17668/
> -----------------------------------------------------------
> 
> (Updated Feb. 3, 2014, 6:49 p.m.)
> 
> 
> Review request for Ambari, Nate Cole and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-4513
>     https://issues.apache.org/jira/browse/AMBARI-4513
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> The expected behavior is Ambari need to start ZooKeeper as an HDFS service dependency
if the users did not start ZooKeeper services prior to starting HDFS.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementController.java
cab12e9 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
2e1c3cd 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ServiceResourceProvider.java
1145b1b 
>   ambari-server/src/main/java/org/apache/ambari/server/metadata/RoleCommandOrder.java
3d13c77 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java
009e0af 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ServiceResourceProviderTest.java
5082dce 
> 
> Diff: https://reviews.apache.org/r/17668/diff/
> 
> 
> Testing
> -------
> 
> OK
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Ambari Main ....................................... SUCCESS [0.066s]
> [INFO] Apache Ambari Project POM ......................... SUCCESS [0.025s]
> [INFO] Ambari Web ........................................ SUCCESS [7.912s]
> [INFO] Ambari Views ...................................... SUCCESS [1.422s]
> [INFO] Ambari Server ..................................... SUCCESS [10:35.494s]
> [INFO] Ambari Agent ...................................... SUCCESS [15.707s]
> [INFO] Ambari Client ..................................... SUCCESS [0.210s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> 
> 
> Thanks,
> 
> Dmytro Sen
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message