ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andrew Onischuk" <aonis...@hortonworks.com>
Subject Re: Review Request 17669: Add support for marking hbase RS instances as DRAINING before decommission
Date Tue, 04 Feb 2014 21:54:31 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17669/#review33646
-----------------------------------------------------------


hbase_excluded_hosts = default("/commandParams/excluded_hosts", "")
hbase_drain_only = default("/commandParams/mark_draining_only", False)

try avoiding default, if it's possible, you said you have no good way of checking if it's
UnknownConfiguration or not, why would you need that, isn't this configs ALWAYS used when
decommision command is comming? Please ping me skype on this, and for now please change if
it's possible to your opinion, else is good.

- Andrew Onischuk


On Feb. 3, 2014, 7:25 p.m., Sumit Mohanty wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17669/
> -----------------------------------------------------------
> 
> (Updated Feb. 3, 2014, 7:25 p.m.)
> 
> 
> Review request for Ambari, Andrew Onischuk and Sid Wagle.
> 
> 
> Bugs: AMBARI-4499
>     https://issues.apache.org/jira/browse/AMBARI-4499
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> See the JIRA.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java
55022cf 
>   ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HBASE/package/files/draining_servers.rb
PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HBASE/package/scripts/hbase_decommission.py
dba89fa 
>   ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HBASE/package/scripts/params.py
1d57fc9 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HBASE/package/files/draining_servers.rb
PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HBASE/package/scripts/hbase_decommission.py
dba89fa 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HBASE/package/scripts/params.py
7db6306 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java
009e0af 
>   ambari-server/src/test/python/stacks/1.3.2/HBASE/test_hbase_master.py 397503e 
>   ambari-server/src/test/python/stacks/1.3.2/configs/default.hbasedecom.json PRE-CREATION

>   ambari-server/src/test/python/stacks/2.0.6/HBASE/test_hbase_master.py 8616fa5 
>   ambari-server/src/test/python/stacks/2.0.6/configs/default.hbasedecom.json PRE-CREATION

>   ambari-server/src/test/resources/stacks/HDP/2.0.7/services/HBASE/metainfo.xml 084576e

> 
> Diff: https://reviews.apache.org/r/17669/diff/
> 
> 
> Testing
> -------
> 
> All python resource based unit tests and AmbariManagementControllerTest tests passed.
> 
> 
> Thanks,
> 
> Sumit Mohanty
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message