ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dmytro Shkvyra" <dshkv...@hortonworks.com>
Subject Re: Review Request 17596: If Ganglia is not installed, server logs hundreds of error messages
Date Tue, 04 Feb 2014 20:44:02 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17596/
-----------------------------------------------------------

(Updated Feb. 4, 2014, 8:44 p.m.)


Review request for Ambari, Mahadev Konar, Nate Cole, Tom Beerbower, and Yusaku Sako.


Changes
-------

As Tom advised I have create new implementation of Resource and add new method to it which
returned evaluated config.
Now JMXPropertyProvider can get evaluated values and UI and other functionality should work
as earlier.


Bugs: AMBARI-4490
    https://issues.apache.org/jira/browse/AMBARI-4490


Repository: ambari


Description
-------

The cause of error messages is that we start use new format properties like "dfs.datanode.http.address":"0.0.0.0:${ambari.dfs.datanode.http.port}".
It means that we have to replace ${ambari.dfs.datanode.http.port} with value of ambari.dfs.datanode.http.port
property from current config.
In this case we need process these value references and keep in mind that:
1) We can have some references in one property, like this "dfs.datanode.http.address":"${ambari.dfs.datanode.http.host}:${ambari.dfs.datanode.http.port}"
2) Also value references can be referenced to another references.
3) Patch have to impact all configs
So, I have created private method postProcessPropertyValue in ResourceImpl.java for resolve
all of value references


Diffs (updated)
-----

  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractProviderModule.java
f39893c 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ConfigurationResourceProvider.java
60a3780 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/EvaluatedResourceImpl.java
PRE-CREATION 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ResourceImpl.java
15fb961 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/EvaluatedResourceImplTest.java
PRE-CREATION 

Diff: https://reviews.apache.org/r/17596/diff/


Testing
-------

Added unitests


Thanks,

Dmytro Shkvyra


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message