Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@ambari.apache.org
Content-Type: multipart/alternative;
 boundary="===============5183555790059525735=="
MIME-Version: 1.0
Subject: Re: Review Request 17523: Create new /blueprints REST endpoint
From: "Mahadev Konar" <mahadev@apache.org>
To: "Yusaku Sako" <yusaku@hortonworks.com>,
 "Mahadev Konar" <mahadev@apache.org>,
 "Sumit Mohanty" <smohanty@hortonworks.com>,
 "Tom Beerbower" <tbeerbower@hortonworks.com>
Cc: "Ambari" <dev@ambari.apache.org>,
 "John Speidel" <jspeidel@hortonworks.com>
Date: Fri, 31 Jan 2014 19:43:07 -0000
Message-ID: <20140131194307.21455.24337@reviews.apache.org>
Auto-Submitted: auto-generated
Sender: "Mahadev Konar" <noreply@reviews.apache.org>
References: <20140130225012.21444.21696@reviews.apache.org>
In-Reply-To: <20140130225012.21444.21696@reviews.apache.org>
Reply-To: "Mahadev Konar" <mahadev@apache.org>

--===============5183555790059525735==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17523/#review33346
-----------------------------------------------------------


John, 
 Arent the upgrade DDL's missing changes to add the blueprint entities on  an upgrade? 

- Mahadev Konar


On Jan. 30, 2014, 10:50 p.m., John Speidel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17523/
> -----------------------------------------------------------
> 
> (Updated Jan. 30, 2014, 10:50 p.m.)
> 
> 
> Review request for Ambari, Mahadev Konar, Sumit Mohanty, Tom Beerbower, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-4467
>     https://issues.apache.org/jira/browse/AMBARI-4467
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Create a new /blueprints REST endpoint. This endpoint represents an 'abstract blueprint' or 'template' and doesn't contain cluster specific details such specific host information.
> 
> This initial jira will be limited to basic blueprint information and will not contain configuration elements. These additional elements will be added in subsequent patches.
> 
> Available operations are get, create and delete. Update is not supported because blueprints are immutable.
> 
> See the associated Apache Jira for an example of a blueprint resource.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/api/resources/BlueprintResourceDefinition.java PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/api/resources/ResourceInstanceFactoryImpl.java 7dcaccb 
>   ambari-server/src/main/java/org/apache/ambari/server/api/services/BlueprintService.java PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java 75b6cb1 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractControllerResourceProvider.java c66ae65 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintResourceProvider.java PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/DefaultProviderModule.java e8765e4 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/spi/Resource.java 52f0cdf 
>   ambari-server/src/main/java/org/apache/ambari/server/orm/dao/BlueprintDAO.java PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/orm/entities/BlueprintEntity.java PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostGroupComponentEntity.java PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostGroupComponentEntityPK.java PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostGroupEntity.java PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostGroupEntityPK.java PRE-CREATION 
>   ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 8b8e285 
>   ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 3f1a080 
>   ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 78dce48 
>   ambari-server/src/main/resources/META-INF/persistence.xml 3b07bd7 
>   ambari-server/src/main/resources/key_properties.json dc7e23a 
>   ambari-server/src/main/resources/properties.json 4a824d3 
>   ambari-server/src/main/resources/upgrade/ddl/Ambari-DDL-MySQL-UPGRADE.sql 509d1cf 
>   ambari-server/src/main/resources/upgrade/ddl/Ambari-DDL-Oracle-UPGRADE.sql a74f2a2 
>   ambari-server/src/main/resources/upgrade/ddl/Ambari-DDL-Postgres-UPGRADE-1.3.0.sql 674d08c 
>   ambari-server/src/test/java/org/apache/ambari/server/api/resources/BlueprintResourceDefinitionTest.java PRE-CREATION 
>   ambari-server/src/test/java/org/apache/ambari/server/api/services/BlueprintServiceTest.java PRE-CREATION 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintResourceProviderTest.java PRE-CREATION 
>   ambari-server/src/test/java/org/apache/ambari/server/orm/dao/BlueprintDAOTest.java PRE-CREATION 
>   ambari-server/src/test/java/org/apache/ambari/server/orm/entities/BlueprintEntityTest.java PRE-CREATION 
>   ambari-server/src/test/java/org/apache/ambari/server/orm/entities/HostGroupComponentEntityTest.java PRE-CREATION 
>   ambari-server/src/test/java/org/apache/ambari/server/orm/entities/HostGroupEntityTest.java PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/17523/diff/
> 
> 
> Testing
> -------
> 
> Added unit tests for new code.
> All unit tests pass.
> Functional tests included creating, getting and deleting blueprint resources.
> 
> 
> Thanks,
> 
> John Speidel
> 
>


--===============5183555790059525735==--