Return-Path: X-Original-To: apmail-ambari-dev-archive@www.apache.org Delivered-To: apmail-ambari-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 5FB2610B4B for ; Thu, 30 Jan 2014 20:54:34 +0000 (UTC) Received: (qmail 25796 invoked by uid 500); 30 Jan 2014 20:54:24 -0000 Delivered-To: apmail-ambari-dev-archive@ambari.apache.org Received: (qmail 25532 invoked by uid 500); 30 Jan 2014 20:54:19 -0000 Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ambari.apache.org Delivered-To: mailing list dev@ambari.apache.org Received: (qmail 25329 invoked by uid 99); 30 Jan 2014 20:54:14 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 30 Jan 2014 20:54:14 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id A4DE11C05B2; Thu, 30 Jan 2014 20:54:12 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============6857636833899800682==" MIME-Version: 1.0 Subject: Re: Review Request 17555: Include missing MSI changes From: "Mahadev Konar" To: "Mahadev Konar" Cc: "Ambari" , "Tom Beerbower" Date: Thu, 30 Jan 2014 20:54:12 -0000 Message-ID: <20140130205412.21445.62986@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Mahadev Konar" X-ReviewGroup: Ambari X-ReviewRequest-URL: https://reviews.apache.org/r/17555/ X-Sender: "Mahadev Konar" References: <20140130201549.21445.36533@reviews.apache.org> In-Reply-To: <20140130201549.21445.36533@reviews.apache.org> Reply-To: "Mahadev Konar" X-ReviewRequest-Repository: ambari --===============6857636833899800682== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17555/#review33250 ----------------------------------------------------------- tom, contrib/ambari-scom/msi/src/GUI_Ambari/Form1.cs and contrib/ambari-scom/msi/src/GUI_Ambari/Form1.resx are missing license headers. - Mahadev Konar On Jan. 30, 2014, 8:15 p.m., Tom Beerbower wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/17555/ > ----------------------------------------------------------- > > (Updated Jan. 30, 2014, 8:15 p.m.) > > > Review request for Ambari and Mahadev Konar. > > > Bugs: AMBARI-3382, AMBARI-3383 and AMBARI-3412 > https://issues.apache.org/jira/browse/AMBARI-3382 > https://issues.apache.org/jira/browse/AMBARI-3383 > https://issues.apache.org/jira/browse/AMBARI-3412 > > > Repository: ambari > > > Description > ------- > > Include the MSI changes that didn't make it into the Apache repo... > > 3412 - Ambari-SCOM MSI have to perform rollback in case of interrupted installation > 3383 - Installation Ambari-SCOM with incorrect DMBS credentials finishes without warning > 3382 - Ambari-SCOM MSI doesn't check if HDP available during installation > > > Diffs > ----- > > contrib/ambari-scom/msi/build.cmd e5a28b8 > contrib/ambari-scom/msi/src/AmbariPackages/ambari-winpkg/scripts/install.ps1 09b38d1 > contrib/ambari-scom/msi/src/AmbariPackages/ambari-winpkg/scripts/uninstall.ps1 10a403f > contrib/ambari-scom/msi/src/AmbariSetupTools/winpkg.ps1 f383652 > contrib/ambari-scom/msi/src/GUI/App.config 58f0a29 > contrib/ambari-scom/msi/src/GUI/Form1.Designer.cs df3168a > contrib/ambari-scom/msi/src/GUI/Form1.cs 9d6cc8c > contrib/ambari-scom/msi/src/GUI/Form1.resx f0005b1 > contrib/ambari-scom/msi/src/GUI/GUI_Ambari.csproj a2e9cc0 > contrib/ambari-scom/msi/src/GUI/Program.cs 59de9d6 > contrib/ambari-scom/msi/src/GUI/Properties/AssemblyInfo.cs 7f9c77f > contrib/ambari-scom/msi/src/GUI/Properties/Resources.Designer.cs 20f852d > contrib/ambari-scom/msi/src/GUI/Properties/Resources.resx 97b0bb7 > contrib/ambari-scom/msi/src/GUI/Properties/Settings.Designer.cs 98559d7 > contrib/ambari-scom/msi/src/GUI/Properties/Settings.settings 5f90ec3 > contrib/ambari-scom/msi/src/GUI_Ambari.sln PRE-CREATION > contrib/ambari-scom/msi/src/GUI_Ambari/App.config PRE-CREATION > contrib/ambari-scom/msi/src/GUI_Ambari/Form1.Designer.cs PRE-CREATION > contrib/ambari-scom/msi/src/GUI_Ambari/Form1.cs PRE-CREATION > contrib/ambari-scom/msi/src/GUI_Ambari/Form1.resx PRE-CREATION > contrib/ambari-scom/msi/src/GUI_Ambari/GUI_Ambari.csproj PRE-CREATION > contrib/ambari-scom/msi/src/GUI_Ambari/Program.cs PRE-CREATION > contrib/ambari-scom/msi/src/GUI_Ambari/Properties/AssemblyInfo.cs PRE-CREATION > contrib/ambari-scom/msi/src/GUI_Ambari/Properties/Resources.Designer.cs PRE-CREATION > contrib/ambari-scom/msi/src/GUI_Ambari/Properties/Resources.resx PRE-CREATION > contrib/ambari-scom/msi/src/GUI_Ambari/Properties/Settings.Designer.cs PRE-CREATION > contrib/ambari-scom/msi/src/GUI_Ambari/Properties/Settings.settings PRE-CREATION > contrib/ambari-scom/msi/src/Result/Ambari_Result.csproj 49fb5b9 > contrib/ambari-scom/msi/src/Result/App.config 58f0a29 > contrib/ambari-scom/msi/src/Result/Program.cs 9c64eb4 > contrib/ambari-scom/msi/src/Result/Properties/AssemblyInfo.cs 4186e66 > contrib/ambari-scom/msi/src/Result/Properties/Resources.Designer.cs 36efa5c > contrib/ambari-scom/msi/src/Result/Properties/Resources.resx 97b0bb7 > contrib/ambari-scom/msi/src/Result/Properties/Settings.Designer.cs d68c2d4 > contrib/ambari-scom/msi/src/Result/Properties/Settings.settings 5f90ec3 > contrib/ambari-scom/msi/src/ambari-scom.wxs 179d575 > contrib/ambari-scom/msi/src/bin/wixca PRE-CREATION > > Diff: https://reviews.apache.org/r/17555/diff/ > > > Testing > ------- > > Manual testing. > > > Thanks, > > Tom Beerbower > > --===============6857636833899800682==--