Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@ambari.apache.org
Content-Type: multipart/alternative;
 boundary="===============4740840210873802769=="
MIME-Version: 1.0
Subject: Re: Review Request 17145: Restart command does not clear stale
 configs flag
From: "Sumit Mohanty" <smohanty@hortonworks.com>
To: "Myroslav Papirkovskyy" <mpapyrkovskyy@hortonworks.com>,
 "Oleksandr Diachenko" <odiachenko@hortonworks.com>
Cc: "Ambari" <dev@ambari.apache.org>,
 "Sumit Mohanty" <smohanty@hortonworks.com>,
 "Dmytro Sen" <dsen@hortonworks.com>
Date: Tue, 21 Jan 2014 23:23:19 -0000
Message-ID: <20140121232319.28235.84161@reviews.apache.org>
Auto-Submitted: auto-generated
Sender: "Sumit Mohanty" <noreply@reviews.apache.org>
References: <20140121182605.4981.68191@reviews.apache.org>
In-Reply-To: <20140121182605.4981.68191@reviews.apache.org>
Reply-To: "Sumit Mohanty" <smohanty@hortonworks.com>

--===============4740840210873802769==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit


> On Jan. 21, 2014, 6:26 p.m., Sumit Mohanty wrote:
> > The change is now to track the latest config versions when the command is RESTART. However, how do we guarantee that new config is actually applied. When I look at the implementation of RESTART in ambari-agent/src/main/python/resource_management/libraries/script/script.py it calls Stop followed by Start. When does the new configuration get applied to the *-site files?
> 
> Dmytro Sen wrote:
>     In ActionQueue.execute_command() configurationTags is cached if START, INSTALL or RESTART command was executed successfully. The new configuration gets applied to the *-site files during Start call(at hbase.py, oozie.py, etc.). If Start fails, then RESTART fails as well, so configurationTags isn't changed.

Thanks. I did not realize that the code change to have Start do the Configure was done. 


- Sumit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17145/#review32386
-----------------------------------------------------------


On Jan. 21, 2014, 2:06 p.m., Dmytro Sen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17145/
> -----------------------------------------------------------
> 
> (Updated Jan. 21, 2014, 2:06 p.m.)
> 
> 
> Review request for Ambari, Myroslav Papirkovskyy and Oleksandr Diachenko.
> 
> 
> Bugs: AMBARI-4369
>     https://issues.apache.org/jira/browse/AMBARI-4369
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> I changed configs in UI making the service get a stale-configs marker. Then I issues RESTART command to various host-components of that service. The stale-configs marker would not go away. Doing a stop and start does clear the stale-config marker.
> Agent should cache configurationTags for any compoment if custom_command RESTART has been completed successfully.
> 
> 
> Diffs
> -----
> 
>   ambari-agent/src/main/python/ambari_agent/ActionQueue.py 4fbae3d 
>   ambari-agent/src/test/python/ambari_agent/TestActionQueue.py b08e54e 
> 
> Diff: https://reviews.apache.org/r/17145/diff/
> 
> 
> Testing
> -------
> 
> ----------------------------------------------------------------------
> Ran 236 tests in 12.946s
> 
> OK
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 17.360s
> [INFO] Finished at: Tue Jan 21 16:56:10 FET 2014
> [INFO] Final Memory: 7M/235M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Dmytro Sen
> 
>


--===============4740840210873802769==--