Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@ambari.apache.org
Content-Type: multipart/alternative;
 boundary="===============3632397020947376734=="
MIME-Version: 1.0
Subject: Re: Review Request 16915: Agent should ensure that the path for
 mapred.hosts
 and mapred.hosts.exclude is present
From: "Dmitro Lisnichenko" <dlysnichenko@hortonworks.com>
To: "Sumit Mohanty" <smohanty@hortonworks.com>,
 "Dmitro Lisnichenko" <dlysnichenko@hortonworks.com>
Cc: "Dmytro Shkvyra" <dshkvyra@hortonworks.com>,
 "Ambari" <dev@ambari.apache.org>
Date: Thu, 16 Jan 2014 21:01:24 -0000
Message-ID: <20140116210124.12830.40857@reviews.apache.org>
Auto-Submitted: auto-generated
Sender: "Dmitro Lisnichenko" <noreply@reviews.apache.org>
References: <20140116205305.24938.20365@reviews.apache.org>
In-Reply-To: <20140116205305.24938.20365@reviews.apache.org>
Reply-To: "Dmitro Lisnichenko" <dlysnichenko@hortonworks.com>

--===============3632397020947376734==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16915/#review32073
-----------------------------------------------------------

Ship it!


As of now, we have no infrastructure for running unit tests of service scripts at ambari-server (troubles with imports and PYTHONPATH). 
Patch looks good to me.

- Dmitro Lisnichenko


On Jan. 16, 2014, 8:53 p.m., Dmytro Shkvyra wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16915/
> -----------------------------------------------------------
> 
> (Updated Jan. 16, 2014, 8:53 p.m.)
> 
> 
> Review request for Ambari, Dmitro Lisnichenko and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-4305
>     https://issues.apache.org/jira/browse/AMBARI-4305
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Add checking and creation of mapred.hosts and mapred.hosts.exclude files by python and puppet (for old versions)
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/stacks/HDP/1.3.4/services/MAPREDUCE/package/scripts/mapreduce.py 41e2af1 
>   ambari-server/src/main/resources/stacks/HDP/1.3.4/services/MAPREDUCE/package/scripts/params.py 55f4303 
> 
> Diff: https://reviews.apache.org/r/16915/diff/
> 
> 
> Testing
> -------
> 
> Tested on Centos6 /HDP-1.3.3 and HDP-1.3.4
> Predefined files were not overriden and not existed files were created.
> 
> 
> Thanks,
> 
> Dmytro Shkvyra
> 
>


--===============3632397020947376734==--