Return-Path: X-Original-To: apmail-ambari-dev-archive@www.apache.org Delivered-To: apmail-ambari-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 1F18B10B22 for ; Thu, 16 Jan 2014 18:32:59 +0000 (UTC) Received: (qmail 77139 invoked by uid 500); 16 Jan 2014 18:32:58 -0000 Delivered-To: apmail-ambari-dev-archive@ambari.apache.org Received: (qmail 77109 invoked by uid 500); 16 Jan 2014 18:32:58 -0000 Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ambari.apache.org Delivered-To: mailing list dev@ambari.apache.org Received: (qmail 77095 invoked by uid 99); 16 Jan 2014 18:32:58 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 16 Jan 2014 18:32:58 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id B42981D418E; Thu, 16 Jan 2014 18:32:57 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============8022299178632113112==" MIME-Version: 1.0 Subject: Re: Review Request 16915: Agent should ensure that the path for mapred.hosts and mapred.hosts.exclude is present From: "Dmytro Shkvyra" To: "Sumit Mohanty" , "Dmitro Lisnichenko" Cc: "Dmytro Shkvyra" , "Ambari" , "Mahadev Konar" Date: Thu, 16 Jan 2014 18:32:57 -0000 Message-ID: <20140116183257.24938.6900@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Dmytro Shkvyra" X-ReviewGroup: Ambari X-ReviewRequest-URL: https://reviews.apache.org/r/16915/ X-Sender: "Dmytro Shkvyra" References: <20140115195728.11940.43950@reviews.apache.org> In-Reply-To: <20140115195728.11940.43950@reviews.apache.org> Reply-To: "Dmytro Shkvyra" X-ReviewRequest-Repository: ambari --===============8022299178632113112== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16915/ ----------------------------------------------------------- (Updated Jan. 16, 2014, 6:32 p.m.) Review request for Ambari, Dmitro Lisnichenko and Sumit Mohanty. Changes ------- I have removed puppet support and added unitest for mapreduce.py I have imported modules by path, because we can have different modules with same name (different stacks - for example) Bugs: AMBARI-4305 https://issues.apache.org/jira/browse/AMBARI-4305 Repository: ambari Description ------- Add checking and creation of mapred.hosts and mapred.hosts.exclude files by python and puppet (for old versions) Diffs (updated) ----- ambari-server/src/main/resources/stacks/HDP/1.3.4/services/MAPREDUCE/package/scripts/mapreduce.py 41e2af1 ambari-server/src/main/resources/stacks/HDP/1.3.4/services/MAPREDUCE/package/scripts/params.py 55f4303 ambari-server/src/test/python/TestHDP_services_Mapreduce.py PRE-CREATION Diff: https://reviews.apache.org/r/16915/diff/ Testing ------- Tested on Centos6 /HDP-1.3.3 and HDP-1.3.4 Predefined files were not overriden and not existed files were created. Thanks, Dmytro Shkvyra --===============8022299178632113112==--