Return-Path: X-Original-To: apmail-ambari-dev-archive@www.apache.org Delivered-To: apmail-ambari-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 4236910210 for ; Tue, 14 Jan 2014 21:48:54 +0000 (UTC) Received: (qmail 21847 invoked by uid 500); 14 Jan 2014 21:48:53 -0000 Delivered-To: apmail-ambari-dev-archive@ambari.apache.org Received: (qmail 21818 invoked by uid 500); 14 Jan 2014 21:48:53 -0000 Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ambari.apache.org Delivered-To: mailing list dev@ambari.apache.org Received: (qmail 21808 invoked by uid 500); 14 Jan 2014 21:48:53 -0000 Delivered-To: apmail-incubator-ambari-dev@incubator.apache.org Received: (qmail 21799 invoked by uid 99); 14 Jan 2014 21:48:53 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 14 Jan 2014 21:48:53 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 770101D42E8; Tue, 14 Jan 2014 21:48:52 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============5445274796119191058==" MIME-Version: 1.0 Subject: Re: Review Request 16869: Run Various Requests in Parallel so that one does not wait on the other. From: "Dmitro Lisnichenko" To: "Sumit Mohanty" , "Oleksandr Diachenko" Cc: "Dmitro Lisnichenko" , "Ambari" Date: Tue, 14 Jan 2014 21:48:52 -0000 Message-ID: <20140114214852.15185.44354@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Dmitro Lisnichenko" X-ReviewGroup: Ambari X-ReviewRequest-URL: https://reviews.apache.org/r/16869/ X-Sender: "Dmitro Lisnichenko" References: <20140114213633.15185.80578@reviews.apache.org> In-Reply-To: <20140114213633.15185.80578@reviews.apache.org> Reply-To: "Dmitro Lisnichenko" X-ReviewRequest-Repository: ambari --===============5445274796119191058== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit > On Jan. 14, 2014, 9:36 p.m., Sumit Mohanty wrote: > > Minor nit. > > > > ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ActionScheduler.java AND > > ambari-server/src/test/java/org/apache/ambari/server/actionmanager/TestActionScheduler.java > > -- Lets revert "import java.util.*;" back to fully expanded I've just disabled this feature in IDEA, so it should not collapse it any more - Dmitro ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16869/#review31806 ----------------------------------------------------------- On Jan. 14, 2014, 9:46 p.m., Dmitro Lisnichenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/16869/ > ----------------------------------------------------------- > > (Updated Jan. 14, 2014, 9:46 p.m.) > > > Review request for Ambari, Oleksandr Diachenko and Sumit Mohanty. > > > Bugs: AMBARI-4290 > https://issues.apache.org/jira/browse/AMBARI-4290 > > > Repository: ambari > > > Description > ------- > > Run Various Requests in Parallel so that one does not wait on the other. > > > Diffs > ----- > > ambari-server/conf/unix/ambari.properties ebb5d9c > ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ActionManager.java af25149 > ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ActionScheduler.java 02c94b8 > ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java a1a25e0 > ambari-server/src/test/java/org/apache/ambari/server/actionmanager/TestActionDBAccessorImpl.java 6f8c884 > ambari-server/src/test/java/org/apache/ambari/server/actionmanager/TestActionManager.java a266cc6 > ambari-server/src/test/java/org/apache/ambari/server/actionmanager/TestActionScheduler.java bce150a > ambari-server/src/test/java/org/apache/ambari/server/agent/TestHeartbeatHandler.java 4e716dc > > Diff: https://reviews.apache.org/r/16869/diff/ > > > Testing > ------- > > Failing test is broken at trunk. > > Running org.apache.ambari.server.agent.TestHeartbeatMonitor > Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 14.533 sec > Running org.apache.ambari.server.agent.TestHeartbeatHandler > Tests run: 23, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 32.334 sec > > Results : > > Failed tests: testDoWork(org.apache.ambari.server.state.scheduler.BatchRequestJobTest): (..) > > Tests run: 1267, Failures: 1, Errors: 0, Skipped: 8 > > [INFO] ------------------------------------------------------------------------ > [INFO] BUILD FAILURE > [INFO] ------------------------------------------------------------------------ > [INFO] Total time: 11:27.673s > [INFO] Finished at: Tue Jan 14 23:27:15 FET 2014 > [INFO] Final Memory: 22M/299M > > > Thanks, > > Dmitro Lisnichenko > > --===============5445274796119191058==--