Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@ambari.apache.org
Content-Type: multipart/alternative;
 boundary="===============7550650511236363508=="
MIME-Version: 1.0
Subject: Re: Review Request 16820: Update '/stacks' endpoint to use the api
 framework
From: "Tom Beerbower" <tbeerbower@hortonworks.com>
To: "Mahadev Konar" <mahadev@apache.org>,
 "Tom Beerbower" <tbeerbower@hortonworks.com>
Cc: "Ambari" <ambari-dev@incubator.apache.org>,
 "John Speidel" <jspeidel@hortonworks.com>
Date: Mon, 13 Jan 2014 20:27:33 -0000
Message-ID: <20140113202733.20236.23923@reviews.apache.org>
Auto-Submitted: auto-generated
Sender: "Tom Beerbower" <noreply@reviews.apache.org>
References: <20140113163338.20236.45656@reviews.apache.org>
In-Reply-To: <20140113163338.20236.45656@reviews.apache.org>
Reply-To: "Tom Beerbower" <tbeerbower@hortonworks.com>

--===============7550650511236363508==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16820/#review31651
-----------------------------------------------------------

Ship it!


The patch looks good. +1

I wonder if we should have a big comment at the top of StacksService and Stacks2Service to make developers aware of the duplicated code and APIs.  Otherwise the 2 stacks may get out of sync.

Is there some sort of deprecation process for the stacks2 API?  I guess that we can just live with the dual stacks API until we bump the API to v2?

- Tom Beerbower


On Jan. 13, 2014, 4:33 p.m., John Speidel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16820/
> -----------------------------------------------------------
> 
> (Updated Jan. 13, 2014, 4:33 p.m.)
> 
> 
> Review request for Ambari, Mahadev Konar and Tom Beerbower.
> 
> 
> Bugs: AMBARI-4277
>     https://issues.apache.org/jira/browse/AMBARI-4277
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Part of the work being done to implement blueprints.
> As a result of the blueprint work, the stacks api will be exposed to users and therefore needs to be updated to use the api framework to be consistent with the other api endpoints.
> 
> We currently have '/stacks' and '/stacks2' endpoints. The '/stacks' endpoint is very old and doesn't use the api framework and is inconsistent with the rest of the api. This endpoint isn't used by the UI or any other internal component and has never been documented. The 'stacks2' endpoint does use the api framework and is consistent with the other endpoints in it's usage except for the naming of the endpoint and some of it's children. This endpoint is currently used by the UI.
> 
> This task will basically clone the functionality of the 'stacks2' endpoint in the 'stacks' endpoint. The 'stacks' endpoint will be augmented with additional information in future tasks as needed by blueprints. Examples are component dependencies and topology tokens in config properties. After this work the 'stacks2' endpoint should basically be deprecated and the UI should eventually be phased over to the new 'stacks' endpoint.
> 
> 
> Diffs
> -----
> 
> 
> Diff: https://reviews.apache.org/r/16820/diff/
> 
> 
> Testing
> -------
> 
> - Functional testing of patch
> -- Both /stacks2 and /stacks endpoints work as expected
> 
> - All unit tests
> 
> ----------------------------------------------------------------------
> Ran 173 tests in 1.562s
> 
> OK
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 17:28.211s
> [INFO] Finished at: Mon Jan 13 11:13:13 EST 2014
> [INFO] Final Memory: 23M/337M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> John Speidel
> 
>


--===============7550650511236363508==--