ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sid Wagle" <swa...@hortonworks.com>
Subject Re: Review Request 17334: Add Passive state for Service, Host, HostComponent
Date Mon, 27 Jan 2014 18:19:38 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17334/#review32843
-----------------------------------------------------------


Few comments:

- We should try to capture orthogonal states like PASSIVE and DECOMMISSIONED as single attribute
on HostComponent, don't have a good name for it, but something like effective_state.

- Does PASSIVE state apply to Service Components state changes?

Rest of the patch looks good.

- Sid Wagle


On Jan. 24, 2014, 10:42 p.m., Nate Cole wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17334/
> -----------------------------------------------------------
> 
> (Updated Jan. 24, 2014, 10:42 p.m.)
> 
> 
> Review request for Ambari, Sumit Mohanty and Sid Wagle.
> 
> 
> Bugs: AMBARI-4419
>     https://issues.apache.org/jira/browse/AMBARI-4419
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Add ability set a new state on Service, Host, HostComponent - a Passive State.
> Passive State is used to maintain control of a unit in Ambari, but skip operations that
include an item. Examples:
> If a Service is Passive, a call to restart all Services should skip a passive one.
> However, said Service can be acted upon, if it is a direct target.
> A restart of a Service will ignore Hosts that are Passive.
> A restart of a Service will ignore HostComponents that are Passive.
> Rolling restarts do not affect items that are marked Passive
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementController.java
26a02a4 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
a9b6364 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/HostRequest.java 12dd0f6

>   ambari-server/src/main/java/org/apache/ambari/server/controller/HostResponse.java 616a1ea

>   ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceComponentHostRequest.java
6b673b0 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceComponentHostResponse.java
a776ac2 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceRequest.java
03ea6a9 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceResponse.java
82b61e8 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostComponentResourceProvider.java
dbc81a2 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostResourceProvider.java
1759826 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ServiceResourceProvider.java
6387255 
>   ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostComponentDesiredStateEntity.java
7f04c51 
>   ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostStateEntity.java
35b9a4d 
>   ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ServiceDesiredStateEntity.java
1af9406 
>   ambari-server/src/main/java/org/apache/ambari/server/state/Host.java 832de26 
>   ambari-server/src/main/java/org/apache/ambari/server/state/PassiveState.java PRE-CREATION

>   ambari-server/src/main/java/org/apache/ambari/server/state/Service.java 5fe2d71 
>   ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponentHost.java
4ce632a 
>   ambari-server/src/main/java/org/apache/ambari/server/state/ServiceImpl.java 0e978ea

>   ambari-server/src/main/java/org/apache/ambari/server/state/host/HostImpl.java f8bf36e

>   ambari-server/src/main/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostImpl.java
d9135c0 
>   ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 4f6068e 
>   ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql b2c255e 
>   ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql f15ccd1 
>   ambari-server/src/main/resources/Ambari-DDL-Postgres-REMOTE-CREATE.sql 0586ba3 
>   ambari-server/src/main/resources/properties.json 1e555c2 
>   ambari-server/src/main/resources/upgrade/ddl/Ambari-DDL-MySQL-UPGRADE.sql 702a8d4 
>   ambari-server/src/main/resources/upgrade/ddl/Ambari-DDL-Oracle-UPGRADE.sql 4edd1a2

>   ambari-server/src/main/resources/upgrade/ddl/Ambari-DDL-Postgres-UPGRADE-1.3.0.sql
ae2e02f 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java
bc2039e 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/HostResourceProviderTest.java
9bf0c94 
>   ambari-server/src/test/java/org/apache/ambari/server/state/ServiceTest.java f9658fa

>   ambari-server/src/test/java/org/apache/ambari/server/state/host/HostTest.java 272a448

>   ambari-server/src/test/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostTest.java
da3e3e1 
> 
> Diff: https://reviews.apache.org/r/17334/diff/
> 
> 
> Testing
> -------
> 
> Change tests:
> org.apache.ambari.server.controller.AmbariManagementControllerTest
> org.apache.ambari.server.controller.internal.HostResourceProviderTest
> org.apache.ambari.server.state.ServiceTest
> org.apache.ambari.server.state.host.HostTest
> org.apache.ambari.server.state.svccomphost.ServiceComponentHostTest
> 
> All tests
> ---------
> Results :
> 
> Tests run: 1287, Failures: 0, Errors: 0, Skipped: 7
> 
> [INFO]
> 
> 
> Thanks,
> 
> Nate Cole
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message