ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tom Beerbower" <tbeerbo...@hortonworks.com>
Subject Re: Review Request 17296: AMBARI-4406 : Create module for Ambari View interfaces
Date Fri, 24 Jan 2014 02:19:50 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17296/
-----------------------------------------------------------

(Updated Jan. 24, 2014, 2:19 a.m.)


Review request for Ambari, Mahadev Konar and Sumit Mohanty.


Bugs: Ambari-4406
    https://issues.apache.org/jira/browse/Ambari-4406


Repository: ambari


Description
-------

Add the public facing interfaces that a developer needs to create an Ambari View. These should
be packaged separately from the rest of ambari server. 


Diffs (updated)
-----

  ambari-server/pom.xml 02fd326 
  ambari-views/pom.xml PRE-CREATION 
  ambari-views/src/main/assemblies/views.xml PRE-CREATION 
  ambari-views/src/main/java/org/apache/ambari/view/NoSuchResourceException.java PRE-CREATION

  ambari-views/src/main/java/org/apache/ambari/view/ReadRequest.java PRE-CREATION 
  ambari-views/src/main/java/org/apache/ambari/view/ResourceAlreadyExistsException.java PRE-CREATION

  ambari-views/src/main/java/org/apache/ambari/view/ResourceProvider.java PRE-CREATION 
  ambari-views/src/main/java/org/apache/ambari/view/SystemException.java PRE-CREATION 
  ambari-views/src/main/java/org/apache/ambari/view/UnsupportedPropertyException.java PRE-CREATION

  ambari-views/src/main/java/org/apache/ambari/view/ViewContext.java PRE-CREATION 
  ambari-views/src/main/java/org/apache/ambari/view/ViewResourceHandler.java PRE-CREATION

  ambari-views/src/test/java/org/apache/ambari/view/NoSuchResourceExceptionTest.java PRE-CREATION

  ambari-views/src/test/java/org/apache/ambari/view/ResourceAlreadyExistsExceptionTest.java
PRE-CREATION 
  ambari-views/src/test/java/org/apache/ambari/view/UnsupportedPropertyExceptionTest.java
PRE-CREATION 
  pom.xml 811f129 

Diff: https://reviews.apache.org/r/17296/diff/


Testing
-------

For the most part these are interfaces.  Added a few simple unit tests for the new exceptions
as part of ambari-views tests. 


All Ambari tests pass :

[INFO] Ambari Main ....................................... SUCCESS [0.771s]
[INFO] Apache Ambari Project POM ......................... SUCCESS [0.241s]
[INFO] Ambari Web ........................................ SUCCESS [15.506s]
[INFO] Ambari Views ...................................... SUCCESS [2.699s]
[INFO] Ambari Server ..................................... SUCCESS [16:30.263s]
[INFO] Ambari Agent ...................................... SUCCESS [1:05.363s]
[INFO] Ambari Client ..................................... SUCCESS [2.415s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------


Thanks,

Tom Beerbower


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message