ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sumit Mohanty" <smoha...@hortonworks.com>
Subject Re: Review Request 17145: Restart command does not clear stale configs flag
Date Tue, 21 Jan 2014 18:26:05 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17145/#review32386
-----------------------------------------------------------


The change is now to track the latest config versions when the command is RESTART. However,
how do we guarantee that new config is actually applied. When I look at the implementation
of RESTART in ambari-agent/src/main/python/resource_management/libraries/script/script.py
it calls Stop followed by Start. When does the new configuration get applied to the *-site
files?

- Sumit Mohanty


On Jan. 21, 2014, 2:06 p.m., Dmytro Sen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17145/
> -----------------------------------------------------------
> 
> (Updated Jan. 21, 2014, 2:06 p.m.)
> 
> 
> Review request for Ambari, Myroslav Papirkovskyy and Oleksandr Diachenko.
> 
> 
> Bugs: AMBARI-4369
>     https://issues.apache.org/jira/browse/AMBARI-4369
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> I changed configs in UI making the service get a stale-configs marker. Then I issues
RESTART command to various host-components of that service. The stale-configs marker would
not go away. Doing a stop and start does clear the stale-config marker.
> Agent should cache configurationTags for any compoment if custom_command RESTART has
been completed successfully.
> 
> 
> Diffs
> -----
> 
>   ambari-agent/src/main/python/ambari_agent/ActionQueue.py 4fbae3d 
>   ambari-agent/src/test/python/ambari_agent/TestActionQueue.py b08e54e 
> 
> Diff: https://reviews.apache.org/r/17145/diff/
> 
> 
> Testing
> -------
> 
> ----------------------------------------------------------------------
> Ran 236 tests in 12.946s
> 
> OK
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 17.360s
> [INFO] Finished at: Tue Jan 21 16:56:10 FET 2014
> [INFO] Final Memory: 7M/235M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Dmytro Sen
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message