ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "John Speidel" <jspei...@hortonworks.com>
Subject Re: Review Request 16989: Update stacks definitions/endpoint with component dependencies
Date Thu, 16 Jan 2014 22:29:27 GMT


> On Jan. 16, 2014, 10:20 p.m., Nate Cole wrote:
> > - In the 2.0.x stack case, there can be a wrinkle in cardinality where HA clusters
can have more than one NN, and no SNN.  Even though the install doesn't do HA, it will still
be possible.
> > - (nit) Imports should be expanded, not using '*'.

Thanks for pointing this out.  To be clear, this is only in the case of a 2.x stack and shouldn't
be an issue with the updated 1.3.4 stack, correct?
Agreed on the imports, I had thought that I had fixed those.  I guess I need to tell IntelliJ
not to do this.  I will fix and update a new patch.


- John


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16989/#review32087
-----------------------------------------------------------


On Jan. 16, 2014, 10:05 p.m., John Speidel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16989/
> -----------------------------------------------------------
> 
> (Updated Jan. 16, 2014, 10:05 p.m.)
> 
> 
> Review request for Ambari, Nate Cole, Sumit Mohanty, and Tom Beerbower.
> 
> 
> Bugs: AMBARI-4325
>     https://issues.apache.org/jira/browse/AMBARI-4325
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Add service/component dependencies to stack definitions and expose via the '/stacks'
endpoint.
> 
> This includes component cardinality, component dependencies and auto-deploy information.
> 
> Currently, this dependency logic is hard coded in the UI code.
> 
> This patch includes the minimal changes including unit testing.  It doesn't include any
usage of the new information and doesn't include changes to StackExtensionHelper, etc.
> These changes will be added in subsequent patches.
> 
> Changes were only made on 1.3.4 stack in this patch.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/state/AutoDeployInfo.java PRE-CREATION

>   ambari-server/src/main/java/org/apache/ambari/server/state/ComponentInfo.java 7be8fc3

>   ambari-server/src/main/java/org/apache/ambari/server/state/DependencyInfo.java PRE-CREATION

>   ambari-server/src/main/resources/stacks/HDP/1.3.4/services/FLUME/metainfo.xml 13eba83

>   ambari-server/src/main/resources/stacks/HDP/1.3.4/services/GANGLIA/metainfo.xml 1406f45

>   ambari-server/src/main/resources/stacks/HDP/1.3.4/services/HBASE/metainfo.xml 129d0ae

>   ambari-server/src/main/resources/stacks/HDP/1.3.4/services/HDFS/metainfo.xml 5f587d3

>   ambari-server/src/main/resources/stacks/HDP/1.3.4/services/HIVE/metainfo.xml dc43ab6

>   ambari-server/src/main/resources/stacks/HDP/1.3.4/services/HUE/metainfo.xml ba580ca

>   ambari-server/src/main/resources/stacks/HDP/1.3.4/services/MAPREDUCE/metainfo.xml 2a91403

>   ambari-server/src/main/resources/stacks/HDP/1.3.4/services/NAGIOS/metainfo.xml 9af461e

>   ambari-server/src/main/resources/stacks/HDP/1.3.4/services/OOZIE/metainfo.xml 1492cd4

>   ambari-server/src/main/resources/stacks/HDP/1.3.4/services/PIG/metainfo.xml 3f3cff1

>   ambari-server/src/main/resources/stacks/HDP/1.3.4/services/SQOOP/metainfo.xml 40a04b7

>   ambari-server/src/main/resources/stacks/HDP/1.3.4/services/WEBHCAT/metainfo.xml 35a090e

>   ambari-server/src/main/resources/stacks/HDP/1.3.4/services/ZOOKEEPER/metainfo.xml b92a270

>   ambari-server/src/test/java/org/apache/ambari/server/api/services/AmbariMetaInfoTest.java
547764e 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java
8f92c09 
>   ambari-server/src/test/resources/stacks/HDP/1.3.4/metainfo.xml PRE-CREATION 
>   ambari-server/src/test/resources/stacks/HDP/1.3.4/services/FLUME/metainfo.xml PRE-CREATION

>   ambari-server/src/test/resources/stacks/HDP/1.3.4/services/GANGLIA/metainfo.xml PRE-CREATION

>   ambari-server/src/test/resources/stacks/HDP/1.3.4/services/HBASE/metainfo.xml PRE-CREATION

>   ambari-server/src/test/resources/stacks/HDP/1.3.4/services/HDFS/metainfo.xml PRE-CREATION

>   ambari-server/src/test/resources/stacks/HDP/1.3.4/services/HIVE/metainfo.xml PRE-CREATION

>   ambari-server/src/test/resources/stacks/HDP/1.3.4/services/HUE/metainfo.xml PRE-CREATION

>   ambari-server/src/test/resources/stacks/HDP/1.3.4/services/MAPREDUCE/metainfo.xml PRE-CREATION

>   ambari-server/src/test/resources/stacks/HDP/1.3.4/services/NAGIOS/metainfo.xml PRE-CREATION

>   ambari-server/src/test/resources/stacks/HDP/1.3.4/services/OOZIE/metainfo.xml PRE-CREATION

>   ambari-server/src/test/resources/stacks/HDP/1.3.4/services/PIG/metainfo.xml PRE-CREATION

>   ambari-server/src/test/resources/stacks/HDP/1.3.4/services/SQOOP/metainfo.xml PRE-CREATION

>   ambari-server/src/test/resources/stacks/HDP/1.3.4/services/WEBHCAT/metainfo.xml PRE-CREATION

>   ambari-server/src/test/resources/stacks/HDP/1.3.4/services/ZOOKEEPER/metainfo.xml PRE-CREATION

> 
> Diff: https://reviews.apache.org/r/16989/diff/
> 
> 
> Testing
> -------
> 
> Manual Functional Tests:
> - manually deployed all components via Ambari UI
> 
> Unit Tests
> - Added unit test coverage
> - All unit tests pass
> 
> 
> Thanks,
> 
> John Speidel
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message