ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dmitro Lisnichenko" <dlysniche...@hortonworks.com>
Subject Re: Review Request 16915: Agent should ensure that the path for mapred.hosts and mapred.hosts.exclude is present
Date Thu, 16 Jan 2014 21:01:24 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16915/#review32073
-----------------------------------------------------------

Ship it!


As of now, we have no infrastructure for running unit tests of service scripts at ambari-server
(troubles with imports and PYTHONPATH). 
Patch looks good to me.

- Dmitro Lisnichenko


On Jan. 16, 2014, 8:53 p.m., Dmytro Shkvyra wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16915/
> -----------------------------------------------------------
> 
> (Updated Jan. 16, 2014, 8:53 p.m.)
> 
> 
> Review request for Ambari, Dmitro Lisnichenko and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-4305
>     https://issues.apache.org/jira/browse/AMBARI-4305
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Add checking and creation of mapred.hosts and mapred.hosts.exclude files by python and
puppet (for old versions)
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/stacks/HDP/1.3.4/services/MAPREDUCE/package/scripts/mapreduce.py
41e2af1 
>   ambari-server/src/main/resources/stacks/HDP/1.3.4/services/MAPREDUCE/package/scripts/params.py
55f4303 
> 
> Diff: https://reviews.apache.org/r/16915/diff/
> 
> 
> Testing
> -------
> 
> Tested on Centos6 /HDP-1.3.3 and HDP-1.3.4
> Predefined files were not overriden and not existed files were created.
> 
> 
> Thanks,
> 
> Dmytro Shkvyra
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message