ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dmytro Shkvyra" <dshkv...@hortonworks.com>
Subject Re: Review Request 16915: Agent should ensure that the path for mapred.hosts and mapred.hosts.exclude is present
Date Thu, 16 Jan 2014 18:32:57 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16915/
-----------------------------------------------------------

(Updated Jan. 16, 2014, 6:32 p.m.)


Review request for Ambari, Dmitro Lisnichenko and Sumit Mohanty.


Changes
-------

I have removed puppet support and added unitest for mapreduce.py I have imported modules by
path, because we can have different modules with same name (different stacks - for example)


Bugs: AMBARI-4305
    https://issues.apache.org/jira/browse/AMBARI-4305


Repository: ambari


Description
-------

Add checking and creation of mapred.hosts and mapred.hosts.exclude files by python and puppet
(for old versions)


Diffs (updated)
-----

  ambari-server/src/main/resources/stacks/HDP/1.3.4/services/MAPREDUCE/package/scripts/mapreduce.py
41e2af1 
  ambari-server/src/main/resources/stacks/HDP/1.3.4/services/MAPREDUCE/package/scripts/params.py
55f4303 
  ambari-server/src/test/python/TestHDP_services_Mapreduce.py PRE-CREATION 

Diff: https://reviews.apache.org/r/16915/diff/


Testing
-------

Tested on Centos6 /HDP-1.3.3 and HDP-1.3.4
Predefined files were not overriden and not existed files were created.


Thanks,

Dmytro Shkvyra


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message