ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "John Speidel" <jspei...@hortonworks.com>
Subject Re: Review Request 16820: Update '/stacks' endpoint to use the api framework
Date Tue, 14 Jan 2014 19:24:56 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16820/
-----------------------------------------------------------

(Updated Jan. 14, 2014, 7:24 p.m.)


Review request for Ambari, Mahadev Konar, Nate Cole, Sumit Mohanty, Sid Wagle, and Tom Beerbower.


Changes
-------

Uploaded patch for completeness


Bugs: AMBARI-4277
    https://issues.apache.org/jira/browse/AMBARI-4277


Repository: ambari


Description
-------

Part of the work being done to implement blueprints.
As a result of the blueprint work, the stacks api will be exposed to users and therefore needs
to be updated to use the api framework to be consistent with the other api endpoints.

We currently have '/stacks' and '/stacks2' endpoints. The '/stacks' endpoint is very old and
doesn't use the api framework and is inconsistent with the rest of the api. This endpoint
isn't used by the UI or any other internal component and has never been documented. The 'stacks2'
endpoint does use the api framework and is consistent with the other endpoints in it's usage
except for the naming of the endpoint and some of it's children. This endpoint is currently
used by the UI.

This task will basically clone the functionality of the 'stacks2' endpoint in the 'stacks'
endpoint. The 'stacks' endpoint will be augmented with additional information in future tasks
as needed by blueprints. Examples are component dependencies and topology tokens in config
properties. After this work the 'stacks2' endpoint should basically be deprecated and the
UI should eventually be phased over to the new 'stacks' endpoint.


Diffs (updated)
-----

  ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaService.java
7a2d2e5 
  ambari-server/src/main/java/org/apache/ambari/server/api/services/Stacks2Service.java PRE-CREATION

  ambari-server/src/main/java/org/apache/ambari/server/api/services/StacksService.java 31c4c31

  ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java 7ca3ea1

  ambari-server/src/test/java/org/apache/ambari/server/api/services/AmbariMetaServiceTest.java
f60c08e 
  ambari-server/src/test/java/org/apache/ambari/server/api/services/Stacks2ServiceTest.java
PRE-CREATION 
  ambari-server/src/test/java/org/apache/ambari/server/api/services/StacksServiceTest.java
9454993 

Diff: https://reviews.apache.org/r/16820/diff/


Testing
-------

- Functional testing of patch
-- Both /stacks2 and /stacks endpoints work as expected

- All unit tests

----------------------------------------------------------------------
Ran 173 tests in 1.562s

OK
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 17:28.211s
[INFO] Finished at: Mon Jan 13 11:13:13 EST 2014
[INFO] Final Memory: 23M/337M
[INFO] ------------------------------------------------------------------------


Thanks,

John Speidel


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message