ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dmitro Lisnichenko" <dlysniche...@hortonworks.com>
Subject Re: Review Request 16859: Add Falcon to the stack for monitoring/Management and add python scripts for managing/monitoring the service.
Date Tue, 14 Jan 2014 18:03:09 GMT


> On Jan. 14, 2014, 5:31 p.m., Dmitro Lisnichenko wrote:
> > Broken indentation at oozie.py;
> > Also it probably makes no sence to comment out rpm declaration at service metainfo.xml

also, falcon_client.py has no status() method. 
also, client.properties file is created with 755 permissions (as executable file)
regarding oozie_falcon client, this method may be not reliable, because user may not always
install client when installing oozie. So it would be better to move all falcon-related code
to configure() method of oozie. Configure command is expected to be issued at all relevant
cases.


- Dmitro


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16859/#review31733
-----------------------------------------------------------


On Jan. 14, 2014, 4:31 p.m., Eugene Chekanskiy wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16859/
> -----------------------------------------------------------
> 
> (Updated Jan. 14, 2014, 4:31 p.m.)
> 
> 
> Review request for Ambari, Andrew Onischuk and Dmitro Lisnichenko.
> 
> 
> Bugs: AMBARI-4263
>     https://issues.apache.org/jira/browse/AMBARI-4263
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Added new service(FALCON). It was split it into 3 components: Falcon Service, Falcon
Client, Falcon Oozie EL. Falcon Oozie EL must be installed on host with Oozie Server(Oozie
Server must be stopped before install). Currently only main parameters(see global.xml) are
configurable(to prevent changing important properties like implementation classes).
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/stacks/HDP/2.0.8/services/FALCON/configuration/global.xml
PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.0.8/services/FALCON/configuration/oozie-site.xml
PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.0.8/services/FALCON/metainfo.xml PRE-CREATION

>   ambari-server/src/main/resources/stacks/HDP/2.0.8/services/FALCON/package/scripts/falcon.py
PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.0.8/services/FALCON/package/scripts/falcon_client.py
PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.0.8/services/FALCON/package/scripts/falcon_oozie_el.py
PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.0.8/services/FALCON/package/scripts/falcon_server.py
PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.0.8/services/FALCON/package/scripts/params.py
PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.0.8/services/FALCON/package/scripts/service_check.py
PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.0.8/services/FALCON/package/scripts/status_params.py
PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.0.8/services/FALCON/package/templates/client.properties.j2
PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.0.8/services/FALCON/package/templates/runtime.properties.j2
PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.0.8/services/FALCON/package/templates/startup.properties.j2
PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.0.8/services/HDFS/package/scripts/hdfs_namenode.py
e26f758 
>   ambari-server/src/main/resources/stacks/HDP/2.0.8/services/HDFS/package/scripts/params.py
a2479c0 
>   ambari-server/src/main/resources/stacks/HDP/2.0.8/services/OOZIE/package/scripts/oozie.py
88be4ae 
> 
> Diff: https://reviews.apache.org/r/16859/diff/
> 
> 
> Testing
> -------
> 
> Component was tested on one node cluster. All components were installed manually using
API.
> 
> 
> Thanks,
> 
> Eugene Chekanskiy
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message