Mailing-List: contact ambari-dev-help@incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: ambari-dev@incubator.apache.org
Date: Fri, 1 Nov 2013 20:24:17 +0000 (UTC)
From: "Sumit Mohanty (JIRA)" <jira@apache.org>
To: ambari-dev@incubator.apache.org
Message-ID: <JIRA.12676169.1382980982190.8562.1383337457950@arcas>
In-Reply-To: <JIRA.12676169.1382980982190@arcas>
References: <JIRA.12676169.1382980982190@arcas>
Subject: [jira] [Comment Edited] (AMBARI-3606) Add ConfigGroup resource
 provider to support API calls
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/AMBARI-3606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13811618#comment-13811618 ] 

Sumit Mohanty edited comment on AMBARI-3606 at 11/1/13 8:23 PM:
----------------------------------------------------------------

_Sorry for the delay. Let's open a separate JIRA for the ones needed to be incorporated._

* What happens when a host gets deleted? Does the ref from CG to host also get deleted? Is there a unit test for that?
* (Minor nit) Javadoc missing for new methods on AmbariManagementController
* ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ConfigGroupResourceProvider.java
** Set<ConfigGroupResponse> getConfigGroups () - is it possible to have a request with more than one predicate, e.g. groupName and hostName?
* These files can be reverted (unused imports or fields)
** ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RequestStatusImpl.java
** ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ResourceImpl.java
** ambari-server/src/main/java/org/apache/ambari/server/state/Clusters.java
** ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClustersImpl.java
* ambari-server/src/main/resources/Ambari-DDL-Postgres-REMOTE-CREATE.sql'
** Should not there be a corresponding change to Ambari-DDL-Postgres-CREATE.sql 

Following unit tests fail:
Tests in error:
*  agentRegistration(org.apache.ambari.server.agent.AgentResourceTest): Guice creation errors:(..)
*  agentHeartBeat(org.apache.ambari.server.agent.AgentResourceTest): Guice creation errors:(..)
*  agentHeartBeatWithEnv(org.apache.ambari.server.agent.AgentResourceTest): Guice creation errors:(..)
*  deserializeClasses(org.apache.ambari.server.agent.AgentResourceTest): Guice creation errors:(..)


was (Author: sumitmohanty):
_Sorry for the delay. Let's open a separate JIRA for the ones needed to be incorporated._

* What happens when a host gets deleted? Does the ref from CG to host also get deleted? Is there a unit test for that?
* (Minor nit) Javadoc missing for new methods on AmbariManagementController
* ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ConfigGroupResourceProvider.java
** Set<ConfigGroupResponse> getConfigGroups () - is it possible to have a request with more than one predicate, e.g. groupName and hostName?
* These files can be reverted (unused imports or fields)
** ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RequestStatusImpl.java
** ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ResourceImpl.java
** ambari-server/src/main/java/org/apache/ambari/server/state/Clusters.java
** ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClustersImpl.java
* ambari-server/src/main/resources/Ambari-DDL-Postgres-REMOTE-CREATE.sql'
** Should not there be a corresponding change to Ambari-DDL-Postgres-CREATE.sql 


> Add ConfigGroup resource provider to support API calls
> ------------------------------------------------------
>
>                 Key: AMBARI-3606
>                 URL: https://issues.apache.org/jira/browse/AMBARI-3606
>             Project: Ambari
>          Issue Type: Task
>          Components: controller
>    Affects Versions: 1.4.2
>            Reporter: Siddharth Wagle
>            Assignee: Siddharth Wagle
>             Fix For: 1.4.3
>
>         Attachments: AMBARI-3606-1.patch, AMBARI-3606.patch
>
>
> Configuration group or Config group (CG) is type of Ambari resource that supports grouping of configuration resources and host resources for a service, service component or host component. Host is identified using the registered hostname of the host and the configuration resource is identified by the type and tag. The CG will have a unique name and CRUD operations will be supported on a CG using the unique group name.
> *GET*
> Get a collections of Config group resources for a service. Query example does not show the expanded view.
> *POST*
> Create a Config group, list of hosts or configurations is not a required field. If the configuration object contains properties, the Ambari server will create a new configuration resource with the new type and tag or throw appropriate exception. Properties provides only the key value pairs which have been changed. These will be applied on the cluster level configurations.
> *PUT*
> Update a config group definition, this API call would expect the object to be sent in its entirety and will atomically update the resource. PUT call can accept properties as well.
> *DELETE*
> Delete a config group resource, this will not do a cascade delete of any other resource.


--
This message was sent by Atlassian JIRA
(v6.1#6144)