ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Siddharth Wagle (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (AMBARI-3672) Add Support to AmbariManagementController to derive configs from Config groups
Date Thu, 07 Nov 2013 18:15:17 GMT

     [ https://issues.apache.org/jira/browse/AMBARI-3672?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Siddharth Wagle updated AMBARI-3672:
------------------------------------

    Attachment: AMBARI-3672-1.patch

[~ncole@hortonworks.com] Thank you for the feedback

Addressed:
1. Property duplication ("tag")
2. Declared the Helper as a Singleton

Comments:
1. At this time the user would need to create a new config group for overriding settings for
a single host that is a part of a group already. Although, this does present a case for keeping
host overrides, the trade-off is that the user can add a second host to this group if and
when needed without need another batch of overrides. Valid point however and we should have
another JIRA to discuss the viability of host overrides along with config groups.

2. Kept the applyCustomConfig and mergeCustomConfig, asis since there were existing unit tests
for these public methods. I agree that we should have a  different refactor JIRA.


> Add Support to AmbariManagementController to derive configs from Config groups
> ------------------------------------------------------------------------------
>
>                 Key: AMBARI-3672
>                 URL: https://issues.apache.org/jira/browse/AMBARI-3672
>             Project: Ambari
>          Issue Type: Task
>          Components: controller
>    Affects Versions: 1.4.2
>            Reporter: Siddharth Wagle
>            Assignee: Siddharth Wagle
>             Fix For: 1.4.3
>
>         Attachments: AMBARI-3672-1.patch, AMBARI-3672.patch
>
>
> Application of the configurations boils down to figuring out the configs for a Service
Host Component when a Task is to be created for the host. Rules to apply configuration changes:
> - Apply cluster desired configs
> - Get all the config groups for the host
> - Apply the overrides per config type.  (In future this can go through config groups
for service then component and host component in that order)



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Mime
View raw message