ambari-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] kasakrisz commented on a change in pull request #17: AMBARI-24833. Create cloud input/output skeleton.
Date Wed, 31 Oct 2018 12:56:01 GMT
kasakrisz commented on a change in pull request #17: AMBARI-24833. Create cloud input/output
skeleton.
URL: https://github.com/apache/ambari-logsearch/pull/17#discussion_r229679354
 
 

 ##########
 File path: ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/conf/LogFeederProps.java
 ##########
 @@ -199,6 +199,16 @@
   @Value("${" + LogFeederConstants.SOLR_URLS + ":}")
   private String solrUrlsStr;
 
+  @LogSearchPropertyDescription(
+    name = LogFeederConstants.CLOUD_STORAGE_MODE,
+    description = "Option to support sending logs to cloud storage. You can choose between
supporting only cloud storage, non-cloud storage or both",
+    examples = {"default", "cloud", "hybrid"},
+    defaultValue = "true",
+    sources = {LogFeederConstants.CLOUD_STORAGE_MODE}
+  )
+  @Value("${" + LogFeederConstants.CLOUD_STORAGE_MODE + ":default}")
+  public String cloudStorageMode;
 
 Review comment:
   Can `cloudStorageMode` have a type of `LogFeederMode` instead of `String`?
   Or `LogFeederMode.fromString(mode)` should throw an informative exception in case of an
invalid value instead of falling back to `LogFeederMode.DEFAULT` like
   ```
   throw new IllegalArgumentException("The value '" + mode + "'is not a valid LogFeederMode!");
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message