Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 9B207200C49 for ; Fri, 24 Feb 2017 15:19:11 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 99FA3160B8B; Fri, 24 Feb 2017 14:19:11 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 7EF57160B83 for ; Fri, 24 Feb 2017 15:19:10 +0100 (CET) Received: (qmail 87029 invoked by uid 500); 24 Feb 2017 14:19:09 -0000 Mailing-List: contact commits-help@ambari.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: ambari-dev@ambari.apache.org Delivered-To: mailing list commits@ambari.apache.org Received: (qmail 86649 invoked by uid 99); 24 Feb 2017 14:19:09 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 24 Feb 2017 14:19:09 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 1726CDFFD8; Fri, 24 Feb 2017 14:19:09 +0000 (UTC) Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: ncole@apache.org To: commits@ambari.apache.org Date: Fri, 24 Feb 2017 14:19:17 -0000 Message-Id: In-Reply-To: <5490771483f546e5adc1f86e7682c8da@git.apache.org> References: <5490771483f546e5adc1f86e7682c8da@git.apache.org> X-Mailer: ASF-Git Admin Mailer Subject: [10/50] ambari git commit: AMBARI-20092. Hive View 2.0: User should be shown with appropriate error message when compute statistics action fails. (dipayanb) archived-at: Fri, 24 Feb 2017 14:19:11 -0000 AMBARI-20092. Hive View 2.0: User should be shown with appropriate error message when compute statistics action fails. (dipayanb) Project: http://git-wip-us.apache.org/repos/asf/ambari/repo Commit: http://git-wip-us.apache.org/repos/asf/ambari/commit/4e7bf34a Tree: http://git-wip-us.apache.org/repos/asf/ambari/tree/4e7bf34a Diff: http://git-wip-us.apache.org/repos/asf/ambari/diff/4e7bf34a Branch: refs/heads/branch-feature-AMBARI-12556 Commit: 4e7bf34a7435148a8ab96fb9e46059189355edf8 Parents: 3e76e47 Author: Dipayan Bhowmick Authored: Wed Feb 22 12:42:34 2017 +0530 Committer: Dipayan Bhowmick Committed: Wed Feb 22 12:43:08 2017 +0530 ---------------------------------------------------------------------- .../src/main/resources/ui/app/components/table-statistics.js | 5 ++++- .../resources/ui/app/routes/databases/database/tables/table.js | 2 ++ .../ui/app/routes/databases/database/tables/table/edit.js | 2 +- 3 files changed, 7 insertions(+), 2 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/ambari/blob/4e7bf34a/contrib/views/hive20/src/main/resources/ui/app/components/table-statistics.js ---------------------------------------------------------------------- diff --git a/contrib/views/hive20/src/main/resources/ui/app/components/table-statistics.js b/contrib/views/hive20/src/main/resources/ui/app/components/table-statistics.js index 1623e0e..0310cbc 100644 --- a/contrib/views/hive20/src/main/resources/ui/app/components/table-statistics.js +++ b/contrib/views/hive20/src/main/resources/ui/app/components/table-statistics.js @@ -17,8 +17,9 @@ */ import Ember from 'ember'; +import UILoggerMixin from '../mixins/ui-logger'; -export default Ember.Component.extend({ +export default Ember.Component.extend(UILoggerMixin, { statsService: Ember.inject.service(), analyseWithStatistics: false, @@ -76,6 +77,7 @@ export default Ember.Component.extend({ Ember.run.later(() => this.closeAndRefresh(), 2 * 1000); }).catch((err) => { this.set('analyseMessage', 'Job failed for analysing statistics of table'); + this.get('logger').danger(`Job failed for analysing statistics of table '${tableName}'`, this.extractError(err)); Ember.run.later(() => this.closeAndRefresh(), 2 * 1000); }); }, @@ -96,6 +98,7 @@ export default Ember.Component.extend({ }).catch((err) => { column.set('isFetchingStats', false); column.set('statsError', true); + this.get('logger').danger(`Job failed for fetching column statistics for column '${column.name}' of table '${tableName}'`, this.extractError(err)); }); }, http://git-wip-us.apache.org/repos/asf/ambari/blob/4e7bf34a/contrib/views/hive20/src/main/resources/ui/app/routes/databases/database/tables/table.js ---------------------------------------------------------------------- diff --git a/contrib/views/hive20/src/main/resources/ui/app/routes/databases/database/tables/table.js b/contrib/views/hive20/src/main/resources/ui/app/routes/databases/database/tables/table.js index 6ee8100..53055cf 100644 --- a/contrib/views/hive20/src/main/resources/ui/app/routes/databases/database/tables/table.js +++ b/contrib/views/hive20/src/main/resources/ui/app/routes/databases/database/tables/table.js @@ -38,6 +38,8 @@ export default Ember.Route.extend(UILoggerMixin, { console.log(model.get('detailedInfo.tableType').toLowerCase()); if (model.get('detailedInfo.tableType').toLowerCase().indexOf('view') === -1) { newTabs = newTabs.rejectBy('name', 'viewInfo'); + } else { + newTabs = newTabs.rejectBy('name', 'statistics'); } controller.set('tabs', newTabs); }, http://git-wip-us.apache.org/repos/asf/ambari/blob/4e7bf34a/contrib/views/hive20/src/main/resources/ui/app/routes/databases/database/tables/table/edit.js ---------------------------------------------------------------------- diff --git a/contrib/views/hive20/src/main/resources/ui/app/routes/databases/database/tables/table/edit.js b/contrib/views/hive20/src/main/resources/ui/app/routes/databases/database/tables/table/edit.js index d9f80e1..2fa61b4 100644 --- a/contrib/views/hive20/src/main/resources/ui/app/routes/databases/database/tables/table/edit.js +++ b/contrib/views/hive20/src/main/resources/ui/app/routes/databases/database/tables/table/edit.js @@ -57,7 +57,7 @@ export default TableMetaRouter.extend(UILoggerMixin, { this._transitionToTables(); }).catch((err) => { this._modalStatus(false, 'Failed to edit table'); - this.get('logger').danger(`Failed to altered table '${settings.table}'`, this.extractError(err)); + this.get('logger').danger(`Failed to alter table '${settings.table}'`, this.extractError(err)); }); }