ambari-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From onechipore...@apache.org
Subject ambari git commit: AMBARI-19465. JS error when user click Alert Link in the popup on the service summary page (onechiporenko)
Date Wed, 11 Jan 2017 14:40:12 GMT
Repository: ambari
Updated Branches:
  refs/heads/trunk 9bf6bdfb1 -> ce08967b9


AMBARI-19465. JS error when user click Alert Link in the popup on the service summary page
(onechiporenko)


Project: http://git-wip-us.apache.org/repos/asf/ambari/repo
Commit: http://git-wip-us.apache.org/repos/asf/ambari/commit/ce08967b
Tree: http://git-wip-us.apache.org/repos/asf/ambari/tree/ce08967b
Diff: http://git-wip-us.apache.org/repos/asf/ambari/diff/ce08967b

Branch: refs/heads/trunk
Commit: ce08967b97c58cc6760f7f5c0547cf24e2af4764
Parents: 9bf6bdf
Author: Oleg Nechiporenko <onechiporenko@apache.org>
Authored: Wed Jan 11 15:50:11 2017 +0200
Committer: Oleg Nechiporenko <onechiporenko@apache.org>
Committed: Wed Jan 11 16:40:08 2017 +0200

----------------------------------------------------------------------
 ambari-web/app/controllers/main/service/info/summary.js | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/ambari/blob/ce08967b/ambari-web/app/controllers/main/service/info/summary.js
----------------------------------------------------------------------
diff --git a/ambari-web/app/controllers/main/service/info/summary.js b/ambari-web/app/controllers/main/service/info/summary.js
index fc423fe..9bdf83a 100644
--- a/ambari-web/app/controllers/main/service/info/summary.js
+++ b/ambari-web/app/controllers/main/service/info/summary.js
@@ -408,13 +408,14 @@ App.MainServiceInfoSummaryController = Em.Controller.extend(App.WidgetSectionMix
         }.property('controller.content'),
         onToggleBlock: function (alert) {
           this.$('#' + alert.context.clientId).toggle('blind', 500);
-          alert.context.set("isCollapsed", !alert.context.get("isCollapsed"));
+          alert.context.toggleProperty('isCollapsed');
         },
-        gotoAlertDetails: function (event) {
-          if (event && event.context) {
+        gotoAlertDetails: function (e) {
+          if (e && e.context) {
             this.get('parentView').hide();
-            App.router.transitionTo('main.alerts.alertDetails', event.context);
+            App.router.transitionTo('main.alerts.alertDetails', e.context);
           }
+          return false;
         },
         closePopup: function () {
           this.get('parentView').hide();


Mime
View raw message