ambari-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From onechipore...@apache.org
Subject ambari git commit: AMBARI-17911. UI calls recommendation API, which returns an empty string so value is invalid, yet UI doesn't show validation error for Atlas configs (onechiporenko)
Date Wed, 27 Jul 2016 09:08:03 GMT
Repository: ambari
Updated Branches:
  refs/heads/trunk 3ef40a408 -> 22b0bd343


AMBARI-17911. UI calls recommendation API, which returns an empty string so value is invalid,
yet UI doesn't show validation error for Atlas configs (onechiporenko)


Project: http://git-wip-us.apache.org/repos/asf/ambari/repo
Commit: http://git-wip-us.apache.org/repos/asf/ambari/commit/22b0bd34
Tree: http://git-wip-us.apache.org/repos/asf/ambari/tree/22b0bd34
Diff: http://git-wip-us.apache.org/repos/asf/ambari/diff/22b0bd34

Branch: refs/heads/trunk
Commit: 22b0bd343b06f6d45763881406a404277cd5147f
Parents: 3ef40a4
Author: Oleg Nechiporenko <onechiporenko@apache.org>
Authored: Wed Jul 27 11:51:07 2016 +0300
Committer: Oleg Nechiporenko <onechiporenko@apache.org>
Committed: Wed Jul 27 12:07:39 2016 +0300

----------------------------------------------------------------------
 .../app/mixins/common/configs/config_recommendation_parser.js       | 1 +
 1 file changed, 1 insertion(+)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/ambari/blob/22b0bd34/ambari-web/app/mixins/common/configs/config_recommendation_parser.js
----------------------------------------------------------------------
diff --git a/ambari-web/app/mixins/common/configs/config_recommendation_parser.js b/ambari-web/app/mixins/common/configs/config_recommendation_parser.js
index 582c083..df7dfe9 100644
--- a/ambari-web/app/mixins/common/configs/config_recommendation_parser.js
+++ b/ambari-web/app/mixins/common/configs/config_recommendation_parser.js
@@ -168,6 +168,7 @@ App.ConfigRecommendationParser = Em.Mixin.create(App.ConfigRecommendations,
{
     if (this.updateInitialOnRecommendations(Em.get(config, 'serviceName'))) {
       Em.set(config, 'initialValue', recommendedValue);
     }
+    Em.tryInvoke(config, 'validate');
     return config;
   },
 


Mime
View raw message