ambari-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ababiic...@apache.org
Subject ambari git commit: AMBARI-14105 Oozie/Hive "Database User" field validation missed. (ababiichuk)
Date Fri, 27 Nov 2015 15:53:58 GMT
Repository: ambari
Updated Branches:
  refs/heads/branch-2.1 691b4839a -> 68e9b6d05


AMBARI-14105 Oozie/Hive "Database User" field validation missed. (ababiichuk)


Project: http://git-wip-us.apache.org/repos/asf/ambari/repo
Commit: http://git-wip-us.apache.org/repos/asf/ambari/commit/68e9b6d0
Tree: http://git-wip-us.apache.org/repos/asf/ambari/tree/68e9b6d0
Diff: http://git-wip-us.apache.org/repos/asf/ambari/diff/68e9b6d0

Branch: refs/heads/branch-2.1
Commit: 68e9b6d05079069d4a72237f5344cf1fa2ab116c
Parents: 691b483
Author: aBabiichuk <ababiichuk@cybervisiontech.com>
Authored: Fri Nov 27 17:53:45 2015 +0200
Committer: aBabiichuk <ababiichuk@cybervisiontech.com>
Committed: Fri Nov 27 17:53:45 2015 +0200

----------------------------------------------------------------------
 .../HIVE/0.12.0.2.0/configuration/hive-site.xml              | 1 +
 .../OOZIE/4.0.0.2.0/configuration/oozie-site.xml             | 1 +
 .../OOZIE/4.2.0.2.3/configuration/oozie-site.xml             | 1 +
 .../stacks/HDP/2.1/services/HIVE/configuration/hive-site.xml | 1 +
 .../HDP/2.1/services/OOZIE/configuration/oozie-site.xml      | 1 +
 .../stacks/HDP/2.2/services/HIVE/configuration/hive-site.xml | 1 +
 .../HDPWIN/2.2/services/HIVE/configuration/hive-site.xml     | 1 +
 .../app/models/configs/objects/service_config_property.js    | 8 ++------
 8 files changed, 9 insertions(+), 6 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/ambari/blob/68e9b6d0/ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/configuration/hive-site.xml
----------------------------------------------------------------------
diff --git a/ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/configuration/hive-site.xml
b/ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/configuration/hive-site.xml
index 9c452d7..bf829b4 100644
--- a/ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/configuration/hive-site.xml
+++ b/ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/configuration/hive-site.xml
@@ -69,6 +69,7 @@ limitations under the License.
     <display-name>Database Username</display-name>
     <description>username to use against metastore database</description>
     <value-attributes>
+      <type>db_user</type>
       <overridable>false</overridable>
     </value-attributes>
   </property>

http://git-wip-us.apache.org/repos/asf/ambari/blob/68e9b6d0/ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/configuration/oozie-site.xml
----------------------------------------------------------------------
diff --git a/ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/configuration/oozie-site.xml
b/ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/configuration/oozie-site.xml
index ff54f47..d8f17b8 100644
--- a/ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/configuration/oozie-site.xml
+++ b/ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/configuration/oozie-site.xml
@@ -227,6 +227,7 @@
       Database user name to use to connect to the database
     </description>
     <value-attributes>
+      <type>db_user</type>
       <overridable>false</overridable>
     </value-attributes>
   </property>

http://git-wip-us.apache.org/repos/asf/ambari/blob/68e9b6d0/ambari-server/src/main/resources/common-services/OOZIE/4.2.0.2.3/configuration/oozie-site.xml
----------------------------------------------------------------------
diff --git a/ambari-server/src/main/resources/common-services/OOZIE/4.2.0.2.3/configuration/oozie-site.xml
b/ambari-server/src/main/resources/common-services/OOZIE/4.2.0.2.3/configuration/oozie-site.xml
index 6acf2e7..813fc2e 100644
--- a/ambari-server/src/main/resources/common-services/OOZIE/4.2.0.2.3/configuration/oozie-site.xml
+++ b/ambari-server/src/main/resources/common-services/OOZIE/4.2.0.2.3/configuration/oozie-site.xml
@@ -108,6 +108,7 @@
       Database user name to use to connect to the database
     </description>
     <value-attributes>
+      <type>db_user</type>
       <overridable>false</overridable>
     </value-attributes>
   </property>

http://git-wip-us.apache.org/repos/asf/ambari/blob/68e9b6d0/ambari-server/src/main/resources/stacks/HDP/2.1/services/HIVE/configuration/hive-site.xml
----------------------------------------------------------------------
diff --git a/ambari-server/src/main/resources/stacks/HDP/2.1/services/HIVE/configuration/hive-site.xml
b/ambari-server/src/main/resources/stacks/HDP/2.1/services/HIVE/configuration/hive-site.xml
index a9ce0e7..b771002 100644
--- a/ambari-server/src/main/resources/stacks/HDP/2.1/services/HIVE/configuration/hive-site.xml
+++ b/ambari-server/src/main/resources/stacks/HDP/2.1/services/HIVE/configuration/hive-site.xml
@@ -67,6 +67,7 @@ limitations under the License.
     <display-name>Database Username</display-name>
     <description>username to use against metastore database</description>
     <value-attributes>
+      <type>db_user</type>
       <overridable>false</overridable>
     </value-attributes>
   </property>

http://git-wip-us.apache.org/repos/asf/ambari/blob/68e9b6d0/ambari-server/src/main/resources/stacks/HDP/2.1/services/OOZIE/configuration/oozie-site.xml
----------------------------------------------------------------------
diff --git a/ambari-server/src/main/resources/stacks/HDP/2.1/services/OOZIE/configuration/oozie-site.xml
b/ambari-server/src/main/resources/stacks/HDP/2.1/services/OOZIE/configuration/oozie-site.xml
index e77cdbb..af1a0a8 100644
--- a/ambari-server/src/main/resources/stacks/HDP/2.1/services/OOZIE/configuration/oozie-site.xml
+++ b/ambari-server/src/main/resources/stacks/HDP/2.1/services/OOZIE/configuration/oozie-site.xml
@@ -226,6 +226,7 @@
       Database user name to use to connect to the database
     </description>
     <value-attributes>
+      <type>db_user</type>
       <overridable>false</overridable>
     </value-attributes>
   </property>

http://git-wip-us.apache.org/repos/asf/ambari/blob/68e9b6d0/ambari-server/src/main/resources/stacks/HDP/2.2/services/HIVE/configuration/hive-site.xml
----------------------------------------------------------------------
diff --git a/ambari-server/src/main/resources/stacks/HDP/2.2/services/HIVE/configuration/hive-site.xml
b/ambari-server/src/main/resources/stacks/HDP/2.2/services/HIVE/configuration/hive-site.xml
index 291a338..f279bf8 100644
--- a/ambari-server/src/main/resources/stacks/HDP/2.2/services/HIVE/configuration/hive-site.xml
+++ b/ambari-server/src/main/resources/stacks/HDP/2.2/services/HIVE/configuration/hive-site.xml
@@ -435,6 +435,7 @@ limitations under the License.
     <display-name>Database Username</display-name>
     <description>username to use against metastore database</description>
     <value-attributes>
+      <type>db_user</type>
       <overridable>false</overridable>
     </value-attributes>
   </property>

http://git-wip-us.apache.org/repos/asf/ambari/blob/68e9b6d0/ambari-server/src/main/resources/stacks/HDPWIN/2.2/services/HIVE/configuration/hive-site.xml
----------------------------------------------------------------------
diff --git a/ambari-server/src/main/resources/stacks/HDPWIN/2.2/services/HIVE/configuration/hive-site.xml
b/ambari-server/src/main/resources/stacks/HDPWIN/2.2/services/HIVE/configuration/hive-site.xml
index cfef137..7e13436 100644
--- a/ambari-server/src/main/resources/stacks/HDPWIN/2.2/services/HIVE/configuration/hive-site.xml
+++ b/ambari-server/src/main/resources/stacks/HDPWIN/2.2/services/HIVE/configuration/hive-site.xml
@@ -404,6 +404,7 @@ limitations under the License.
     <display-name>Database Username</display-name>
     <description>username to use against metastore database</description>
     <value-attributes>
+      <type>db_user</type>
       <overridable>false</overridable>
     </value-attributes>
   </property>

http://git-wip-us.apache.org/repos/asf/ambari/blob/68e9b6d0/ambari-web/app/models/configs/objects/service_config_property.js
----------------------------------------------------------------------
diff --git a/ambari-web/app/models/configs/objects/service_config_property.js b/ambari-web/app/models/configs/objects/service_config_property.js
index 3fb1fa5..0172156 100644
--- a/ambari-web/app/models/configs/objects/service_config_property.js
+++ b/ambari-web/app/models/configs/objects/service_config_property.js
@@ -484,14 +484,10 @@ App.ServiceConfigProperty = Em.Object.extend({
           }
           break;
         case 'user':
-          if (!validator.isValidUNIXUser(value)){
-            this.set('errorMessage', 'Username is not valid');
-            isError = true;
-          }
-          break;
         case 'database':
+        case 'db_user':
           if (!validator.isValidDbName(value)){
-            this.set('errorMessage', 'Database is not valid');
+            this.set('errorMessage', 'Value is not valid');
             isError = true;
           }
           break;


Mime
View raw message