ambari-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From alexantone...@apache.org
Subject [1/2] ambari git commit: AMBARI-12119. Configs: dialog is very hard to read with long values (alexantonenko)
Date Wed, 24 Jun 2015 12:55:45 GMT
Repository: ambari
Updated Branches:
  refs/heads/branch-2.1 8677c8cd9 -> 9d5d3a187


AMBARI-12119. Configs: dialog is very hard to read with long values (alexantonenko)


Project: http://git-wip-us.apache.org/repos/asf/ambari/repo
Commit: http://git-wip-us.apache.org/repos/asf/ambari/commit/61ad2c5a
Tree: http://git-wip-us.apache.org/repos/asf/ambari/tree/61ad2c5a
Diff: http://git-wip-us.apache.org/repos/asf/ambari/diff/61ad2c5a

Branch: refs/heads/branch-2.1
Commit: 61ad2c5a0e19105ca69461bb1cb198d3cc3ed5f4
Parents: 8677c8c
Author: Alex Antonenko <hiveww@gmail.com>
Authored: Wed Jun 24 15:16:52 2015 +0300
Committer: Alex Antonenko <hiveww@gmail.com>
Committed: Wed Jun 24 15:55:41 2015 +0300

----------------------------------------------------------------------
 ambari-web/app/styles/application.less          | 26 ++++++++++++++++++++
 .../modal_popups/dependent_configs_list.hbs     | 12 ++++-----
 2 files changed, 32 insertions(+), 6 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/ambari/blob/61ad2c5a/ambari-web/app/styles/application.less
----------------------------------------------------------------------
diff --git a/ambari-web/app/styles/application.less b/ambari-web/app/styles/application.less
index 07fb5c2..42ca66e 100644
--- a/ambari-web/app/styles/application.less
+++ b/ambari-web/app/styles/application.less
@@ -5676,16 +5676,42 @@ input[type="radio"].align-checkbox, input[type="checkbox"].align-checkbox
{
   }
 }
 
+
+@config-dependency-t-name-width: 180px;
+@config-dependency-t-service-width: 100px;
+@config-dependency-t-group-width: 140px;
+@config-dependency-t-filename-width: 150px;
+@config-dependency-t-value-width: 230px;
+
 #config-dependencies {
   max-height: 500px;
   overflow-y: visible;
   td {
     min-width: 120px;
+    word-break: break-all;
   }
   td.check-box-col {
     min-width: 5px;
     width: 5px;
   }
+  td.config-dependency-name {
+    min-width: @config-dependency-t-name-width;
+  }
+  td.config-dependency-service {
+    min-width: @config-dependency-t-service-width;
+    max-width: @config-dependency-t-service-width;
+  }
+  td.config-dependency-group {
+    max-width: @config-dependency-t-group-width;
+  }
+  td.config-dependency-filename {
+    max-width: @config-dependency-t-filename-width;
+  }
+  td.config-dependency-value,
+  td.config-dependency-recommended-value {
+    width: @config-dependency-t-value-width;
+    min-width: @config-dependency-t-value-width;
+  }
 }
 
 .path-link {

http://git-wip-us.apache.org/repos/asf/ambari/blob/61ad2c5a/ambari-web/app/templates/common/modal_popups/dependent_configs_list.hbs
----------------------------------------------------------------------
diff --git a/ambari-web/app/templates/common/modal_popups/dependent_configs_list.hbs b/ambari-web/app/templates/common/modal_popups/dependent_configs_list.hbs
index b5a8220..7b7be9f 100644
--- a/ambari-web/app/templates/common/modal_popups/dependent_configs_list.hbs
+++ b/ambari-web/app/templates/common/modal_popups/dependent_configs_list.hbs
@@ -36,17 +36,17 @@
     {{#each config in view.parentView.configs}}
       <tr>
         <td class="check-box-col">{{view Em.Checkbox checkedBinding="config.saveRecommended"}}</td>
-        <td>{{config.propertyName}}</td>
-        <td>{{config.serviceDisplayName}}</td>
-        <td>
+        <td class="config-dependency-name">{{config.propertyName}}</td>
+        <td class="config-dependency-service">{{config.serviceDisplayName}}</td>
+        <td class="config-dependency-group">
           <span {{bindAttr class="config.allowChangeGroup::not-active-link"}} ><a
href="javascript:void(null);" class="black"
             {{action showSelectGroupPopup config.serviceName target="App.router.mainServiceInfoConfigsController"}}>
             {{config.configGroup}}
           </a></span>
         </td>
-        <td>{{config.fileName}}</td>
-        <td>{{config.value}}</td>
-        <td>
+        <td class="config-dependency-filename">{{config.fileName}}</td>
+        <td class="config-dependency-value">{{config.value}}</td>
+        <td class="config-dependency-recommended-value">
           {{#if config.isDeleted}}
             <i>{{t common.removed}}</i>
           {{else}}


Mime
View raw message