ambari-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From yus...@apache.org
Subject [1/2] git commit: Revert "AMBARI-5161 Customize Services step load: change calls to asynchronous. (atkach)"
Date Thu, 20 Mar 2014 19:53:24 GMT
Repository: ambari
Updated Branches:
  refs/heads/trunk 46de892c1 -> 6cb293b27


Revert "AMBARI-5161 Customize Services step load: change calls to asynchronous. (atkach)"

This reverts commit b6b56cfeb600cd1be788245843f57ed2c6306072.


Project: http://git-wip-us.apache.org/repos/asf/ambari/repo
Commit: http://git-wip-us.apache.org/repos/asf/ambari/commit/6cb293b2
Tree: http://git-wip-us.apache.org/repos/asf/ambari/tree/6cb293b2
Diff: http://git-wip-us.apache.org/repos/asf/ambari/diff/6cb293b2

Branch: refs/heads/trunk
Commit: 6cb293b27fdc7c5e861717c43425d585e7fa2cde
Parents: fe79eab
Author: Yusaku Sako <yusaku@hortonworks.com>
Authored: Thu Mar 20 12:49:29 2014 -0700
Committer: Yusaku Sako <yusaku@hortonworks.com>
Committed: Thu Mar 20 12:53:16 2014 -0700

----------------------------------------------------------------------
 ambari-web/app/controllers/wizard.js            | 25 +++++++-------------
 .../app/controllers/wizard/step7_controller.js  |  8 +------
 ambari-web/app/routes/add_service_routes.js     |  4 ++--
 ambari-web/app/routes/installer.js              |  3 +--
 ambari-web/app/templates/wizard/step7.hbs       |  7 +-----
 ambari-web/app/utils/ajax.js                    |  7 +++++-
 ambari-web/app/utils/config.js                  | 18 ++++++--------
 7 files changed, 27 insertions(+), 45 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/ambari/blob/6cb293b2/ambari-web/app/controllers/wizard.js
----------------------------------------------------------------------
diff --git a/ambari-web/app/controllers/wizard.js b/ambari-web/app/controllers/wizard.js
index eabb904..f69ff3e 100644
--- a/ambari-web/app/controllers/wizard.js
+++ b/ambari-web/app/controllers/wizard.js
@@ -691,23 +691,16 @@ App.WizardController = Em.Controller.extend({
   /**
    * load advanced configs from server
    */
-  loadAdvancedConfigs: function (dependentController) {
-    var self = this;
-    var counter = this.get('content.services').filterProperty('isSelected').length;
-    var loadAdvancedConfigResult = [];
-    dependentController.set('isAdvancedConfigLoaded', false);
-    this.get('content.services').filterProperty('isSelected').mapProperty('serviceName').forEach(function
(_serviceName) {
-      App.config.loadAdvancedConfig(_serviceName, function(properties){
-        loadAdvancedConfigResult.pushObjects(properties);
-        counter--;
-        //pass configs to controller after last call is completed
-        if (counter === 0) {
-          self.set('content.advancedServiceConfig', loadAdvancedConfigResult);
-          self.setDBProperty('advancedServiceConfig', loadAdvancedConfigResult);
-          dependentController.set('isAdvancedConfigLoaded', true);
-        }
-      });
+  loadAdvancedConfigs: function () {
+    var configs = (this.getDBProperty('advancedServiceConfig')) ? this.getDBProperty('advancedServiceConfig')
: [];
+    this.get('content.services').filterProperty('isSelected', true).mapProperty('serviceName').forEach(function
(_serviceName) {
+      var serviceComponents = App.config.loadAdvancedConfig(_serviceName);
+      if (serviceComponents) {
+        configs = configs.concat(serviceComponents);
+      }
     }, this);
+    this.set('content.advancedServiceConfig', configs);
+    this.setDBProperty('advancedServiceConfig', configs);
   },
   /**
    * Load serviceConfigProperties to model

http://git-wip-us.apache.org/repos/asf/ambari/blob/6cb293b2/ambari-web/app/controllers/wizard/step7_controller.js
----------------------------------------------------------------------
diff --git a/ambari-web/app/controllers/wizard/step7_controller.js b/ambari-web/app/controllers/wizard/step7_controller.js
index 48310c7..0adbd7f 100644
--- a/ambari-web/app/controllers/wizard/step7_controller.js
+++ b/ambari-web/app/controllers/wizard/step7_controller.js
@@ -62,8 +62,6 @@ App.WizardStep7Controller = Em.Controller.extend({
 
   serviceConfigsData: require('data/service_configs'),
 
-  isAdvancedConfigLoaded: true,
-
   isSubmitDisabled: function () {
     return (!this.stepConfigs.filterProperty('showConfig', true).everyProperty('errorCount',
0) || this.get("miscModalVisible"));
   }.property('stepConfigs.@each.errorCount', 'miscModalVisible'),
@@ -344,9 +342,6 @@ App.WizardStep7Controller = Em.Controller.extend({
    */
   loadStep: function () {
     console.log("TRACE: Loading step7: Configure Services");
-    if (!this.get('isAdvancedConfigLoaded')) {
-      return;
-    }
     this.clearStep();
     //STEP 1: Load advanced configs
     var advancedConfigs = this.get('content.advancedServiceConfig');
@@ -408,8 +403,7 @@ App.WizardStep7Controller = Em.Controller.extend({
     if (this.get('content.skipConfigStep')) {
       App.router.send('next');
     }
-  }.observes('isAdvancedConfigLoaded'),
-
+  },
   getConfigTags: function() {
     App.ajax.send({
       name: 'config.tags.sync',

http://git-wip-us.apache.org/repos/asf/ambari/blob/6cb293b2/ambari-web/app/routes/add_service_routes.js
----------------------------------------------------------------------
diff --git a/ambari-web/app/routes/add_service_routes.js b/ambari-web/app/routes/add_service_routes.js
index d2ac777..5b38e3b 100644
--- a/ambari-web/app/routes/add_service_routes.js
+++ b/ambari-web/app/routes/add_service_routes.js
@@ -185,9 +185,9 @@ module.exports = App.WizardRoute.extend({
       var controller = router.get('addServiceController');
       controller.setCurrentStep('4');
       controller.dataLoading().done(function () {
-        var wizardStep7Controller = router.get('wizardStep7Controller');
         controller.loadAllPriorSteps();
-        controller.loadAdvancedConfigs(wizardStep7Controller);
+        controller.loadAdvancedConfigs();
+        var wizardStep7Controller = router.get('wizardStep7Controller');
         wizardStep7Controller.set('wizardController', controller);
         controller.connectOutlet('wizardStep7', controller.get('content'));
       })

http://git-wip-us.apache.org/repos/asf/ambari/blob/6cb293b2/ambari-web/app/routes/installer.js
----------------------------------------------------------------------
diff --git a/ambari-web/app/routes/installer.js b/ambari-web/app/routes/installer.js
index 0c9080d..9408adb 100644
--- a/ambari-web/app/routes/installer.js
+++ b/ambari-web/app/routes/installer.js
@@ -280,7 +280,6 @@ module.exports = Em.Route.extend({
     next: function (router) {
       var controller = router.get('installerController');
       var wizardStep6Controller = router.get('wizardStep6Controller');
-      var wizardStep7Controller = router.get('wizardStep7Controller');
 
       if (wizardStep6Controller.validate()) {
         controller.saveSlaveComponentHosts(wizardStep6Controller);
@@ -288,7 +287,7 @@ module.exports = Em.Route.extend({
         controller.setDBProperty('serviceConfigProperties', null);
         controller.setDBProperty('advancedServiceConfig', null);
         controller.setDBProperty('serviceConfigGroups', null);
-        controller.loadAdvancedConfigs(wizardStep7Controller);
+        controller.loadAdvancedConfigs();
         router.transitionTo('step7');
       }
     }

http://git-wip-us.apache.org/repos/asf/ambari/blob/6cb293b2/ambari-web/app/templates/wizard/step7.hbs
----------------------------------------------------------------------
diff --git a/ambari-web/app/templates/wizard/step7.hbs b/ambari-web/app/templates/wizard/step7.hbs
index b18d294..d5a60cc 100644
--- a/ambari-web/app/templates/wizard/step7.hbs
+++ b/ambari-web/app/templates/wizard/step7.hbs
@@ -23,12 +23,7 @@
       {{t installer.step7.body}}
     </div>
 
-    {{#if isAdvancedConfigLoaded}}
-      {{view App.ServicesConfigView}}
-    {{else}}
-      <div class="spinner"></div>
-    {{/if}}
-
+    {{view App.ServicesConfigView}}
 
     <div class="btn-area">
         <a class="btn" {{action back}}>&larr; {{t common.back}}</a>

http://git-wip-us.apache.org/repos/asf/ambari/blob/6cb293b2/ambari-web/app/utils/ajax.js
----------------------------------------------------------------------
diff --git a/ambari-web/app/utils/ajax.js b/ambari-web/app/utils/ajax.js
index 85695b8..6cd7d79 100644
--- a/ambari-web/app/utils/ajax.js
+++ b/ambari-web/app/utils/ajax.js
@@ -299,7 +299,12 @@ var urls = {
 
   'config.advanced': {
     'real': '{stack2VersionUrl}/stackServices/{serviceName}/configurations?fields=*',
-    'mock': '/data/wizard/stack/hdp/version{stackVersion}/{serviceName}.json'
+    'mock': '/data/wizard/stack/hdp/version{stackVersion}/{serviceName}.json',
+    'format': function() {
+      return {
+        async: false
+      };
+    }
   },
   'config.advanced.global': {
     'real': '{stack2VersionUrl}/stackServices?fields=configurations/StackConfigurations/type',

http://git-wip-us.apache.org/repos/asf/ambari/blob/6cb293b2/ambari-web/app/utils/config.js
----------------------------------------------------------------------
diff --git a/ambari-web/app/utils/config.js b/ambari-web/app/utils/config.js
index e979d08..a05b497 100644
--- a/ambari-web/app/utils/config.js
+++ b/ambari-web/app/utils/config.js
@@ -20,6 +20,7 @@ var App = require('app');
 var stringUtils = require('utils/string_utils');
 
 var categotyConfigs = require('data/service_configs');
+var serviceComponents = {};
 var configGroupsByTag = [];
 
 App.config = Em.Object.create({
@@ -750,19 +751,19 @@ App.config = Em.Object.create({
    * @param serviceName
    * @return {*}
    */
-  loadAdvancedConfig: function (serviceName, callback) {
+  loadAdvancedConfig: function (serviceName) {
     App.ajax.send({
       name: 'config.advanced',
       sender: this,
       data: {
         serviceName: serviceName,
         stack2VersionUrl: App.get('stack2VersionURL'),
-        stackVersion: App.get('currentStackVersionNumber'),
-        callback: callback
+        stackVersion: App.get('currentStackVersionNumber')
       },
-      success: 'loadAdvancedConfigSuccess',
-      error: 'loadAdvancedConfigError'
+      success: 'loadAdvancedConfigSuccess'
     });
+    return serviceComponents[serviceName];
+    //TODO clean serviceComponents
   },
 
   loadAdvancedConfigSuccess: function (data, opt, params) {
@@ -792,13 +793,8 @@ App.config = Em.Object.create({
           });
         }
       }, this);
+      serviceComponents[data.items[0].StackConfigurations.service_name] = properties;
     }
-    params.callback(properties);
-  },
-
-  loadAdvancedConfigError: function (request, ajaxOptions, error, opt, params) {
-    console.log('ERROR: failed to load stack configs for', params.serviceName);
-    params.callback([]);
   },
 
   /**


Mime
View raw message