ambari-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jai...@apache.org
Subject git commit: Revert "AMBARI-5161 Customize Services step load: change calls to asynchronous. (atkach)"
Date Fri, 21 Mar 2014 23:28:22 GMT
Repository: ambari
Updated Branches:
  refs/heads/trunk fae3fa56d -> a5e372543


Revert "AMBARI-5161 Customize Services step load: change calls to asynchronous. (atkach)"

This reverts commit ccde6bc4ce0a6daf45fee98b3b25bb759cf72aa9.


Project: http://git-wip-us.apache.org/repos/asf/ambari/repo
Commit: http://git-wip-us.apache.org/repos/asf/ambari/commit/a5e37254
Tree: http://git-wip-us.apache.org/repos/asf/ambari/tree/a5e37254
Diff: http://git-wip-us.apache.org/repos/asf/ambari/diff/a5e37254

Branch: refs/heads/trunk
Commit: a5e372543e3c89b69318e89ba9c3fad4f9695a36
Parents: fae3fa5
Author: Jaimin Jetly <jaimin@hortonworks.com>
Authored: Fri Mar 21 16:16:22 2014 -0700
Committer: Jaimin Jetly <jaimin@hortonworks.com>
Committed: Fri Mar 21 16:16:22 2014 -0700

----------------------------------------------------------------------
 .../controllers/main/service/info/configs.js    |  5 +---
 ambari-web/app/controllers/wizard.js            | 25 +++++++-------------
 .../app/controllers/wizard/step7_controller.js  |  5 ----
 ambari-web/app/routes/add_service_routes.js     |  4 ++--
 ambari-web/app/routes/installer.js              |  3 +--
 ambari-web/app/templates/wizard/step7.hbs       |  9 ++-----
 ambari-web/app/utils/ajax.js                    |  4 ++--
 ambari-web/app/utils/config.js                  | 19 ++++++---------
 8 files changed, 24 insertions(+), 50 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/ambari/blob/a5e37254/ambari-web/app/controllers/main/service/info/configs.js
----------------------------------------------------------------------
diff --git a/ambari-web/app/controllers/main/service/info/configs.js b/ambari-web/app/controllers/main/service/info/configs.js
index beac1b7..d824dd0 100644
--- a/ambari-web/app/controllers/main/service/info/configs.js
+++ b/ambari-web/app/controllers/main/service/info/configs.js
@@ -342,10 +342,7 @@ App.MainServiceInfoConfigsController = Em.Controller.extend({
     //STEP 2: Create an array of objects defining tag names to be polled and new tag names
to be set after submit
     this.setServiceConfigTags(this.loadedClusterSiteToTagMap);
     //STEP 3: Load advanced configs from server
-    var advancedConfigs = [];
-    App.config.loadAdvancedConfig(serviceName, function (properties) {
-      advancedConfigs.pushObjects(properties);
-    }, true);
+    var advancedConfigs = App.config.loadAdvancedConfig(serviceName) || [];
     //STEP 4: Load on-site config by service from server
     var configGroups = App.router.get('configurationController').getConfigsByTags(this.get('serviceConfigTags'));
     //STEP 5: Merge global and on-site configs with pre-defined

http://git-wip-us.apache.org/repos/asf/ambari/blob/a5e37254/ambari-web/app/controllers/wizard.js
----------------------------------------------------------------------
diff --git a/ambari-web/app/controllers/wizard.js b/ambari-web/app/controllers/wizard.js
index eabb904..f69ff3e 100644
--- a/ambari-web/app/controllers/wizard.js
+++ b/ambari-web/app/controllers/wizard.js
@@ -691,23 +691,16 @@ App.WizardController = Em.Controller.extend({
   /**
    * load advanced configs from server
    */
-  loadAdvancedConfigs: function (dependentController) {
-    var self = this;
-    var counter = this.get('content.services').filterProperty('isSelected').length;
-    var loadAdvancedConfigResult = [];
-    dependentController.set('isAdvancedConfigLoaded', false);
-    this.get('content.services').filterProperty('isSelected').mapProperty('serviceName').forEach(function
(_serviceName) {
-      App.config.loadAdvancedConfig(_serviceName, function(properties){
-        loadAdvancedConfigResult.pushObjects(properties);
-        counter--;
-        //pass configs to controller after last call is completed
-        if (counter === 0) {
-          self.set('content.advancedServiceConfig', loadAdvancedConfigResult);
-          self.setDBProperty('advancedServiceConfig', loadAdvancedConfigResult);
-          dependentController.set('isAdvancedConfigLoaded', true);
-        }
-      });
+  loadAdvancedConfigs: function () {
+    var configs = (this.getDBProperty('advancedServiceConfig')) ? this.getDBProperty('advancedServiceConfig')
: [];
+    this.get('content.services').filterProperty('isSelected', true).mapProperty('serviceName').forEach(function
(_serviceName) {
+      var serviceComponents = App.config.loadAdvancedConfig(_serviceName);
+      if (serviceComponents) {
+        configs = configs.concat(serviceComponents);
+      }
     }, this);
+    this.set('content.advancedServiceConfig', configs);
+    this.setDBProperty('advancedServiceConfig', configs);
   },
   /**
    * Load serviceConfigProperties to model

http://git-wip-us.apache.org/repos/asf/ambari/blob/a5e37254/ambari-web/app/controllers/wizard/step7_controller.js
----------------------------------------------------------------------
diff --git a/ambari-web/app/controllers/wizard/step7_controller.js b/ambari-web/app/controllers/wizard/step7_controller.js
index 63c672f..0adbd7f 100644
--- a/ambari-web/app/controllers/wizard/step7_controller.js
+++ b/ambari-web/app/controllers/wizard/step7_controller.js
@@ -62,8 +62,6 @@ App.WizardStep7Controller = Em.Controller.extend({
 
   serviceConfigsData: require('data/service_configs'),
 
-  isAdvancedConfigLoaded: true,
-
   isSubmitDisabled: function () {
     return (!this.stepConfigs.filterProperty('showConfig', true).everyProperty('errorCount',
0) || this.get("miscModalVisible"));
   }.property('stepConfigs.@each.errorCount', 'miscModalVisible'),
@@ -344,9 +342,6 @@ App.WizardStep7Controller = Em.Controller.extend({
    */
   loadStep: function () {
     console.log("TRACE: Loading step7: Configure Services");
-    if (!this.get('isAdvancedConfigLoaded')) {
-      return;
-    }
     this.clearStep();
     //STEP 1: Load advanced configs
     var advancedConfigs = this.get('content.advancedServiceConfig');

http://git-wip-us.apache.org/repos/asf/ambari/blob/a5e37254/ambari-web/app/routes/add_service_routes.js
----------------------------------------------------------------------
diff --git a/ambari-web/app/routes/add_service_routes.js b/ambari-web/app/routes/add_service_routes.js
index d2ac777..5b38e3b 100644
--- a/ambari-web/app/routes/add_service_routes.js
+++ b/ambari-web/app/routes/add_service_routes.js
@@ -185,9 +185,9 @@ module.exports = App.WizardRoute.extend({
       var controller = router.get('addServiceController');
       controller.setCurrentStep('4');
       controller.dataLoading().done(function () {
-        var wizardStep7Controller = router.get('wizardStep7Controller');
         controller.loadAllPriorSteps();
-        controller.loadAdvancedConfigs(wizardStep7Controller);
+        controller.loadAdvancedConfigs();
+        var wizardStep7Controller = router.get('wizardStep7Controller');
         wizardStep7Controller.set('wizardController', controller);
         controller.connectOutlet('wizardStep7', controller.get('content'));
       })

http://git-wip-us.apache.org/repos/asf/ambari/blob/a5e37254/ambari-web/app/routes/installer.js
----------------------------------------------------------------------
diff --git a/ambari-web/app/routes/installer.js b/ambari-web/app/routes/installer.js
index 86747c3..d23d4cc 100644
--- a/ambari-web/app/routes/installer.js
+++ b/ambari-web/app/routes/installer.js
@@ -285,7 +285,6 @@ module.exports = Em.Route.extend({
     next: function (router) {
       var controller = router.get('installerController');
       var wizardStep6Controller = router.get('wizardStep6Controller');
-      var wizardStep7Controller = router.get('wizardStep7Controller');
 
       if (wizardStep6Controller.validate()) {
         controller.saveSlaveComponentHosts(wizardStep6Controller);
@@ -293,7 +292,7 @@ module.exports = Em.Route.extend({
         controller.setDBProperty('serviceConfigProperties', null);
         controller.setDBProperty('advancedServiceConfig', null);
         controller.setDBProperty('serviceConfigGroups', null);
-        controller.loadAdvancedConfigs(wizardStep7Controller);
+        controller.loadAdvancedConfigs();
         router.transitionTo('step7');
       }
     }

http://git-wip-us.apache.org/repos/asf/ambari/blob/a5e37254/ambari-web/app/templates/wizard/step7.hbs
----------------------------------------------------------------------
diff --git a/ambari-web/app/templates/wizard/step7.hbs b/ambari-web/app/templates/wizard/step7.hbs
index b10434f..d5a60cc 100644
--- a/ambari-web/app/templates/wizard/step7.hbs
+++ b/ambari-web/app/templates/wizard/step7.hbs
@@ -23,12 +23,7 @@
       {{t installer.step7.body}}
     </div>
 
-    {{#if isAdvancedConfigLoaded}}
-      {{view App.ServicesConfigView}}
-    {{else}}
-      <div class="spinner"></div>
-    {{/if}}
-
+    {{view App.ServicesConfigView}}
 
     <div class="btn-area">
         <a class="btn" {{action back}}>&larr; {{t common.back}}</a>
@@ -37,4 +32,4 @@
                 class="btn btn-success pull-right" {{bindAttr disabled="isSubmitDisabled"}}
           {{action submit target="controller"}}>{{t common.next}} &rarr;</a>
     </div>
-</div>
+</div>
\ No newline at end of file

http://git-wip-us.apache.org/repos/asf/ambari/blob/a5e37254/ambari-web/app/utils/ajax.js
----------------------------------------------------------------------
diff --git a/ambari-web/app/utils/ajax.js b/ambari-web/app/utils/ajax.js
index 0e1c4db..8c76974 100644
--- a/ambari-web/app/utils/ajax.js
+++ b/ambari-web/app/utils/ajax.js
@@ -300,9 +300,9 @@ var urls = {
   'config.advanced': {
     'real': '{stack2VersionUrl}/stackServices/{serviceName}/configurations?fields=*',
     'mock': '/data/wizard/stack/hdp/version{stackVersion}/{serviceName}.json',
-    'format': function (data) {
+    'format': function() {
       return {
-        async: !data.sync
+        async: false
       };
     }
   },

http://git-wip-us.apache.org/repos/asf/ambari/blob/a5e37254/ambari-web/app/utils/config.js
----------------------------------------------------------------------
diff --git a/ambari-web/app/utils/config.js b/ambari-web/app/utils/config.js
index 89a4a62..a05b497 100644
--- a/ambari-web/app/utils/config.js
+++ b/ambari-web/app/utils/config.js
@@ -20,6 +20,7 @@ var App = require('app');
 var stringUtils = require('utils/string_utils');
 
 var categotyConfigs = require('data/service_configs');
+var serviceComponents = {};
 var configGroupsByTag = [];
 
 App.config = Em.Object.create({
@@ -750,20 +751,19 @@ App.config = Em.Object.create({
    * @param serviceName
    * @return {*}
    */
-  loadAdvancedConfig: function (serviceName, callback, sync) {
+  loadAdvancedConfig: function (serviceName) {
     App.ajax.send({
       name: 'config.advanced',
       sender: this,
       data: {
         serviceName: serviceName,
         stack2VersionUrl: App.get('stack2VersionURL'),
-        stackVersion: App.get('currentStackVersionNumber'),
-        callback: callback,
-        sync: sync
+        stackVersion: App.get('currentStackVersionNumber')
       },
-      success: 'loadAdvancedConfigSuccess',
-      error: 'loadAdvancedConfigError'
+      success: 'loadAdvancedConfigSuccess'
     });
+    return serviceComponents[serviceName];
+    //TODO clean serviceComponents
   },
 
   loadAdvancedConfigSuccess: function (data, opt, params) {
@@ -793,13 +793,8 @@ App.config = Em.Object.create({
           });
         }
       }, this);
+      serviceComponents[data.items[0].StackConfigurations.service_name] = properties;
     }
-    params.callback(properties);
-  },
-
-  loadAdvancedConfigError: function (request, ajaxOptions, error, opt, params) {
-    console.log('ERROR: failed to load stack configs for', params.serviceName);
-    params.callback([]);
   },
 
   /**


Mime
View raw message